Pimcore X provides TargetGroup Object in Action Array (#299)

* Pimcore X provides TargetGroup Object in Action Array

Pimcore X now provides TargetGroup Object in Action Array instead of id
also some isset checks for php8.1

* Update src/Targeting/ActionHandler/AssignTargetGroupAndSegment.php

Co-authored-by: Bernhard Rusch <[email protected]>

Author: 2 people

src/Targeting/ActionHandler/AssignTargetGroupAndSegment.php

@@ -101,9 +101,14 @@ public function apply(VisitorInfo $visitorInfo, array $action, Rule $rule = null
         }
 
         $targetGroupId = $action['targetGroup'] ?? null;
-        $targetGroup = TargetGroup::getById($targetGroupId);
+        if ($targetGroupId instanceof TargetGroup) {
+            $targetGroup = $targetGroupId;
+            $targetGroupId = $targetGroup->getId();
+        } else {
+            $targetGroup = TargetGroup::getById($targetGroupId);
+        }
 
-        if ($action['trackActivity'] && $targetGroup) {
+        if (isset($action['trackActivity']) && $action['trackActivity'] && $targetGroup) {
             $totalWeight = $action['weight'];
             if ($visitorInfo->hasTargetGroupAssignment($targetGroup)) {
                 $assignedTargetGroup = $visitorInfo->getTargetGroupAssignment($targetGroup);
@@ -113,7 +118,7 @@ public function apply(VisitorInfo $visitorInfo, array $action, Rule $rule = null
             $this->activityManager->trackActivity(new TargetGroupAssignActivity($customer, $targetGroup, $action['weight'], $totalWeight));
         }
 
-        if ($action['assignSegment'] === 'assign_only' || $action['assignSegment'] === 'assign_consider_weight') {
+        if (isset($action['assignSegment']) && ($action['assignSegment'] === 'assign_only' || $action['assignSegment'] === 'assign_consider_weight')) {
             //get segment based on target group
             $segments = $this->segmentManager->getSegments();
             $segments->setCondition('targetGroup = ?', $targetGroupId);