Skip to content

Commit de98f9e

Browse files
authored
LinkActivityDefinition preview doesn't work: Create PreviewGenerator (#494)
* LinkActivityDefinition preview doesn't work: Create PreviewGenerator * Move to PreviewGenerator namespace * Fix deprecation
1 parent e1caae8 commit de98f9e

File tree

4 files changed

+45
-2
lines changed

4 files changed

+45
-2
lines changed

install/class_source/class_LinkActivityDefinition_export.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,7 @@
513513
"group": "CustomerManagement",
514514
"showAppLoggerTab": false,
515515
"linkGeneratorReference": "@CustomerManagementFrameworkBundle\\LinkGenerator\\LinkActivityDefinitionLinkGenerator",
516+
"previewGeneratorReference": "@CustomerManagementFrameworkBundle\\PreviewGenerator\\LinkActivityDefinitionPreviewGenerator",
516517
"compositeIndices": [],
517518
"showFieldLookup": false,
518519
"propertyVisibility": {

src/Controller/Preview/ObjectPreviewController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
class ObjectPreviewController extends FrontendController
2828
{
2929
/**
30-
* @Route("/link-activity-definition-preview")
30+
* @Route("/link-activity-definition-preview", name="cmf_link_activity_definition_preview")
3131
*/
3232
public function linkActivityDefinitionPreviewAction(Request $request): Response
3333
{
34-
$activityDefinition = LinkActivityDefinition::getById($request->get('pimcore_object_preview'));
34+
$activityDefinition = LinkActivityDefinition::getById($request->query->getInt('pimcore_object_preview'));
3535

3636
return $this->render(
3737
'@PimcoreCustomerManagementFramework/preview/object_preview/link_activity_definition_preview.html.twig',
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
<?php
2+
3+
/**
4+
* Pimcore
5+
*
6+
* This source file is available under two different licenses:
7+
* - GNU General Public License version 3 (GPLv3)
8+
* - Pimcore Commercial License (PCL)
9+
* Full copyright and license information is available in
10+
* LICENSE.md which is distributed with this source code.
11+
*
12+
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
13+
* @license http://www.pimcore.org/license GPLv3 and PCL
14+
*/
15+
16+
namespace CustomerManagementFrameworkBundle\PreviewGenerator;
17+
18+
use Pimcore\Model\DataObject\ClassDefinition\PreviewGeneratorInterface;
19+
use Pimcore\Model\DataObject\Concrete;
20+
use Symfony\Component\Routing\RouterInterface;
21+
22+
class LinkActivityDefinitionPreviewGenerator implements PreviewGeneratorInterface
23+
{
24+
public function __construct(protected RouterInterface $router)
25+
{
26+
}
27+
28+
public function generatePreviewUrl(Concrete $object, array $params): string
29+
{
30+
return $this->router->generate(
31+
'cmf_link_activity_definition_preview',
32+
['pimcore_object_preview' => $object->getId()]
33+
);
34+
}
35+
36+
public function getPreviewConfig(Concrete $object): array
37+
{
38+
return [];
39+
}
40+
}

src/Resources/config/services.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,8 @@ services:
163163
arguments:
164164
- '%pimcore_customer_management_framework.url_activity_tracker.linkCmfcPlaceholder%'
165165

166+
CustomerManagementFrameworkBundle\PreviewGenerator\LinkActivityDefinitionPreviewGenerator: ~
167+
166168
cmf.link-activity-definition.linkgenerator:
167169
alias: CustomerManagementFrameworkBundle\LinkGenerator\LinkActivityDefinitionLinkGenerator
168170
deprecated:

0 commit comments

Comments
 (0)