Cleanup

Author: markus-moser

assets/studio/js/src/modules/data-importer/components/tabs/import-logs/filter-sidebar/filter-sidebar.tsx

@@ -138,7 +138,7 @@ export const FilterSidebar = (): React.JSX.Element => {
               <Input
                 onChange={ (e) => {
                   const value = e.target.value
-                  setMessage(value !== '' ? value : null)
+                  setMessage(value === '' ? null : value)
                 } }
                 value={ message ?? undefined }
               />
@@ -152,7 +152,7 @@ export const FilterSidebar = (): React.JSX.Element => {
                 min="0"
                 onChange={ (e) => {
                   const value = e.target.value
-                  setRelatedObjectId(value !== '' ? parseInt(value) : null)
+                  setRelatedObjectId(value === '' ? null : Number.parseInt(value))
                 } }
                 step="1"
                 type="number"
@@ -168,7 +168,7 @@ export const FilterSidebar = (): React.JSX.Element => {
                 min="0"
                 onChange={ (e) => {
                   const value = e.target.value
-                  setPid(value !== '' ? parseInt(value) : null)
+                  setPid(value === '' ? null : Number.parseInt(value))
                 } }
                 step="1"
                 type="number"

assets/studio/js/src/modules/data-importer/components/tabs/import-logs/hooks/use-refresh-interval/use-refresh-interval.ts

@@ -26,7 +26,7 @@ export const useRefreshInterval = (onRefresh: () => void): UseRefreshIntervalRet
       return
     }
 
-    const intervalMs = parseInt(refreshInterval) * 1000
+    const intervalMs = Number.parseInt(refreshInterval) * 1000
     const intervalId = setInterval(() => {
       stableOnRefresh()
     }, intervalMs)

assets/studio/js/src/modules/data-importer/components/tabs/import-logs/import-logs.tsx

@@ -142,7 +142,7 @@ export const ImportLogs = (props: ImportLogsProps): React.JSX.Element => {
                   { value: '60', label: t('application-logger.refresh-interval.seconds', { seconds: 60 }) }
                 ] }
                 placeholder={ t('application-logger.refresh-interval.select') }
-                validate={ (value) => !isNaN(parseInt(value)) && parseInt(value) > 0 }
+                validate={ (value) => !Number.isNaN(Number.parseInt(value)) && Number.parseInt(value) > 0 }
                 value={ refreshInterval }
               />
             </Flex>

assets/studio/js/src/modules/data-importer/components/tabs/steps/advanced-mapping-modal/advanced-mapping-modal.tsx

@@ -19,7 +19,7 @@ import { StepTransformations } from './step-transformations/step-transformations
 import { StepTarget } from './step-target/step-target'
 import { useStyles } from './advanced-mapping-modal.styles'
 
-export type { ClassAttribute }
+export { type ClassAttribute } from '../../../../types'
 
 export interface AdvancedMappingModalProps {
   open: boolean

assets/studio/js/src/modules/data-importer/components/tabs/steps/advanced-mapping-modal/preview-panel/preview-panel.tsx

@@ -97,15 +97,15 @@ export const PreviewPanel = (props: PreviewPanelProps): React.JSX.Element => {
   }, [isImportError])
 
   const fetchResultPreview = (record: number): void => {
-    const currentConfig: Record<string, object> | undefined = props.currentMappingItem !== undefined
-      ? {
+    const currentConfig: Record<string, object> | undefined = props.currentMappingItem === undefined
+      ? undefined
+      : {
           mappingConfig: [props.currentMappingItem] as object[],
           ...(props.baseConfig?.loaderConfig !== undefined && { loaderConfig: props.baseConfig.loaderConfig as object }),
           ...(props.baseConfig?.interpreterConfig !== undefined && { interpreterConfig: props.baseConfig.interpreterConfig as object }),
           ...(props.baseConfig?.resolverConfig !== undefined && { resolverConfig: props.baseConfig.resolverConfig as object }),
           ...(props.baseConfig?.processingConfig !== undefined && { processingConfig: props.baseConfig.processingConfig as object })
         }
-      : undefined
 
     setResultRequest({
       name: props.configName,
@@ -120,7 +120,7 @@ export const PreviewPanel = (props: PreviewPanelProps): React.JSX.Element => {
     if (props.mode !== 'result') return
     if (resultPreviewResponse === undefined) return
     const rawPreviews = resultPreviewResponse.transformationResultPreviews ?? []
-    setPreviews(props.currentMappingItem !== undefined ? rawPreviews.slice(0, 1) : rawPreviews)
+    setPreviews(props.currentMappingItem === undefined ? rawPreviews : rawPreviews.slice(0, 1))
   }, [props.mode, resultPreviewResponse, props.currentMappingItem])
 
   useEffect(() => {

assets/studio/js/src/modules/data-importer/components/tabs/steps/advanced-mapping-modal/step-target/classification-store-key-modal/classification-store-key-modal.tsx

@@ -68,7 +68,7 @@ export const ClassificationStoreKeyModal = ({
       transformationResultType,
       start,
       limit: pageSize,
-      searchfilter: searchTerm !== '' ? searchTerm : undefined
+      searchfilter: searchTerm === '' ? undefined : searchTerm
     },
     {
       skip: !open
@@ -93,7 +93,7 @@ export const ClassificationStoreKeyModal = ({
     [t]
   )
 
-  const selectedRows = selectedRowId !== null ? { [selectedRowId]: true } : undefined
+  const selectedRows = selectedRowId === null ? undefined : { [selectedRowId]: true }
 
   return (
     <Modal

assets/studio/js/src/modules/data-importer/dynamic-types/transformer/load-data-object/load-data-object-transformer-form.tsx

@@ -15,7 +15,7 @@ import { useClassDefinitionCollectionQuery } from '@pimcore/studio-ui-bundle/api
 import { TransformerSettingsLayout } from '../transformer-settings-layout'
 import { useBundleDataImporterDataTypeLoadClassAttributesQuery } from '../../../data-importer-api-slice.gen'
 
-const SYSTEM_ATTRIBUTES = ['id', 'path', 'key']
+const SYSTEM_ATTRIBUTES = new Set(['id', 'path', 'key'])
 
 interface LoadDataObjectTransformerConfig {
   loadStrategy?: string
@@ -73,7 +73,7 @@ export const LoadDataObjectTransformerForm = ({ settings, onChange }: LoadDataOb
     attributeName !== undefined &&
     attributeName !== null &&
     attributeName !== '' &&
-    !SYSTEM_ATTRIBUTES.includes(attributeName)
+    !SYSTEM_ATTRIBUTES.has(attributeName)
 
   return (
     <TransformerSettingsLayout>
@@ -162,7 +162,7 @@ export const LoadDataObjectTransformerForm = ({ settings, onChange }: LoadDataOb
             </>
           ) }
 
-          { !isAttribute && <div style={ { height: 0 } } /> }
+          { isAttribute ? null : <div style={ { height: 0 } } /> }
         </>
       ) }
     </TransformerSettingsLayout>

assets/studio/js/src/modules/data-importer/utils/transformers.ts

@@ -123,8 +123,8 @@ function mergeOptionConfig<T extends { type?: string, settings?: Record<string,
     ...existingConfig,
     ...formConfig,
     settings: {
-      ...(existingConfig?.settings ?? {}),
-      ...(formConfig.settings ?? {})
+      ...existingConfig?.settings,
+      ...formConfig.settings
     }
   }
 }