Skip to content

Commit 4e49467

Browse files
authored
Fix TypeError, when getEmail() is null (#56)
* Fix TypeError, when getEmail() is null * Apply php-cs-fixer changes --------- Co-authored-by: blankse <blankse@users.noreply.github.com>
1 parent 8b1779b commit 4e49467

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/Document/Newsletter/AddressSourceAdapter/DefaultAdapter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public function getParamsForSingleSending(int $limit, int $offset): array
142142
$containers = [];
143143

144144
foreach ($objects as $object) {
145-
if (method_exists($object, 'getEmail')) {
145+
if (method_exists($object, 'getEmail') && $object->getEmail()) {
146146
$containers[] = new SendingParamContainer($object->getEmail(), [
147147
'gender' => method_exists($object, 'getGender') ? $object->getGender() : '',
148148
'firstname' => method_exists($object, 'getFirstname') ? $object->getFirstname() : '',

src/Installer.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private function addUserPermission(): void
7979
foreach (self::USER_PERMISSIONS as $permission) {
8080
// check if the permission already exists
8181
$permissionExists = $db->executeStatement('SELECT `key` FROM users_permission_definitions WHERE `key` = :key', ['key' => $permission]);
82-
if(!$permissionExists) {
82+
if (!$permissionExists) {
8383
$db->insert('users_permission_definitions', [
8484
$db->quoteIdentifier('key') => $permission,
8585
$db->quoteIdentifier('category') => self::USER_PERMISSION_CATEGORY,
@@ -139,11 +139,11 @@ private function modifyEnumTypes(array $enums): void
139139

140140
private function removeNewsLetterDocTypes(): void
141141
{
142-
foreach(SettingsStore::getIdsByScope(self::SETTINGS_STORE_SCOPE) as $id) {
142+
foreach (SettingsStore::getIdsByScope(self::SETTINGS_STORE_SCOPE) as $id) {
143143
$newsletterDocType = SettingsStore::get($id, self::SETTINGS_STORE_SCOPE);
144-
if($newsletterDocType) {
144+
if ($newsletterDocType) {
145145
$data = json_decode($newsletterDocType->getData(), true);
146-
if(!empty($data) && $data['type'] === self::DOCTYPE) {
146+
if (!empty($data) && $data['type'] === self::DOCTYPE) {
147147
SettingsStore::delete($id, self::SETTINGS_STORE_SCOPE);
148148
}
149149
}

0 commit comments

Comments
 (0)