feat: add Velocity Units (#8)

cpave3 · web-flow · commit fff05653b8d8 · 2020-04-05T10:12:55.000+02:00
* feat: added velocity unit type


fix: Added correct unit systems to velocity units

* added .idea to gitignore

* fix: adjusted spelling, added aliases

Added aliases for Mile based Velocity Units as per code review.

* fix: Adjust test to account for added unit types
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
+.idea/
 .git
 clover.xml
 coveralls-upload.json
diff --git a/src/Unit/Velocity.php b/src/Unit/Velocity.php
@@ -0,0 +1,12 @@
+<?php
+namespace PhpUnitConversion\Unit;
+
+use PhpUnitConversion\Unit;
+use PhpUnitConversion\UnitType;
+
+class Velocity extends Unit
+{
+    const TYPE = UnitType::VELOCITY;
+
+    const BASE_UNIT = Velocity\MeterPerSecond::class;
+}
diff --git a/src/Unit/Velocity/FootPerHour.php b/src/Unit/Velocity/FootPerHour.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class FootPerHour extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/11811;
+
+    const SYMBOL = 'fph';
+    const LABEL = 'foot per hour';
+}
diff --git a/src/Unit/Velocity/FootPerMinute.php b/src/Unit/Velocity/FootPerMinute.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class FootPerMinute extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/196.85;
+
+    const SYMBOL = 'fpm';
+    const LABEL = 'foot per minute';
+}
diff --git a/src/Unit/Velocity/FootPerSecond.php b/src/Unit/Velocity/FootPerSecond.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class FootPerSecond extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/3.280840;
+
+    const SYMBOL = 'fps';
+    const LABEL = 'foot per second';
+}
diff --git a/src/Unit/Velocity/InchPerHour.php b/src/Unit/Velocity/InchPerHour.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class InchPerHour extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/141732.3;
+
+    const SYMBOL = 'iph';
+    const LABEL = 'inch per hour';
+}
diff --git a/src/Unit/Velocity/InchPerMinute.php b/src/Unit/Velocity/InchPerMinute.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class InchPerMinute extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/2362.205;
+
+    const SYMBOL = 'ipm';
+    const LABEL = 'inch per minute';
+}
diff --git a/src/Unit/Velocity/InchPerSecond.php b/src/Unit/Velocity/InchPerSecond.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class InchPerSecond extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/39.37008;
+
+    const SYMBOL = 'ips';
+    const LABEL = 'inch per second';
+}
diff --git a/src/Unit/Velocity/KiloMeterPerHour.php b/src/Unit/Velocity/KiloMeterPerHour.php
@@ -0,0 +1,13 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Metric;
+use PhpUnitConversion\Unit\Velocity;
+
+class KiloMeterPerHour extends Velocity implements Metric
+{
+    const FACTOR = 1/3.6;
+
+    const SYMBOL = 'km/h';
+    const LABEL = 'kilometer per hour';
+}
diff --git a/src/Unit/Velocity/Knot.php b/src/Unit/Velocity/Knot.php
@@ -0,0 +1,13 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Metric;
+use PhpUnitConversion\Unit\Velocity;
+
+class Knot extends Velocity implements Metric
+{
+    const FACTOR = 1/1.943844;
+
+    const SYMBOL = 'kn';
+    const LABEL = 'knot';
+}
diff --git a/src/Unit/Velocity/MeterPerSecond.php b/src/Unit/Velocity/MeterPerSecond.php
@@ -0,0 +1,16 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Metric;
+use PhpUnitConversion\Unit\Velocity;
+use PhpUnitConversion\Traits\BaseUnit;
+
+class MeterPerSecond extends Velocity implements Metric
+{
+    use BaseUnit;
+
+    const FACTOR = 1;
+
+    const SYMBOL = 'm/s';
+    const LABEL = 'meter per second';
+}
diff --git a/src/Unit/Velocity/MilePerHour.php b/src/Unit/Velocity/MilePerHour.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class MilePerHour extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1/2.236936;
+
+    const SYMBOL = 'mph';
+    const LABEL = 'mile per hour';
+}
diff --git a/src/Unit/Velocity/MilePerMinute.php b/src/Unit/Velocity/MilePerMinute.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class MilePerMinute extends Velocity implements Imperial, USC
+{
+    const FACTOR = 26.82240;
+
+    const SYMBOL = 'mpm';
+    const LABEL = 'mile per minute';
+}
diff --git a/src/Unit/Velocity/MilePerSecond.php b/src/Unit/Velocity/MilePerSecond.php
@@ -0,0 +1,14 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+use PhpUnitConversion\System\Imperial;
+use PhpUnitConversion\System\USC;
+use PhpUnitConversion\Unit\Velocity;
+
+class MilePerSecond extends Velocity implements Imperial, USC
+{
+    const FACTOR = 1609.344;
+
+    const SYMBOL = 'mps';
+    const LABEL = 'mile per second';
+}
diff --git a/src/Unit/Velocity/MilesPerHour.php b/src/Unit/Velocity/MilesPerHour.php
@@ -0,0 +1,6 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+class MilesPerHour extends MilePerHour
+{
+}
diff --git a/src/Unit/Velocity/MilesPerMinute.php b/src/Unit/Velocity/MilesPerMinute.php
@@ -0,0 +1,6 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+class MilesPerMinute extends MilePerMinute
+{
+}
diff --git a/src/Unit/Velocity/MilesPerSecond.php b/src/Unit/Velocity/MilesPerSecond.php
@@ -0,0 +1,6 @@
+<?php
+namespace PhpUnitConversion\Unit\Velocity;
+
+class MilesPerSecond extends MilePerSecond
+{
+}
diff --git a/src/UnitType.php b/src/UnitType.php
@@ -14,4 +14,5 @@ class UnitType extends Enum
     const TIME = 5;
     const TEMPERATURE = 6;
     const AMOUNT = 7;
+    const VELOCITY = 8;
 }
diff --git a/tests/Unit/VelocityTest.php b/tests/Unit/VelocityTest.php
@@ -0,0 +1,75 @@
+<?php
+namespace PhpUnitConversionTest\Unit;
+
+use PHPUnit\Framework\TestCase;
+use PhpUnitConversion\Unit\Velocity;
+use PhpUnitConversion\Unit\Volume;
+
+class VelocityTest extends TestCase
+{
+    public function testFromFootPerHour()
+    {
+        $volumeUnit = new Velocity\FootPerHour(100000);
+        $this->assertEquals('8.467 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(3));
+    }
+
+    public function testFromFootPerMinute()
+    {
+        $volumeUnit = new Velocity\FootPerMinute(100000);
+        $this->assertEquals('508.001 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(3));
+    }
+
+    public function testFromFootPerSecond()
+    {
+        $volumeUnit = new Velocity\FootPerSecond(100000);
+        $this->assertEquals('30480 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(0));
+    }
+
+    public function testFromMilesPerHour()
+    {
+        $volumeUnit = new Velocity\MilePerHour(100000);
+        $this->assertEquals('44704 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(0));
+    }
+
+    public function testFromKiloMetersPerHour()
+    {
+        $volumeUnit = new Velocity\KiloMeterPerHour(100000);
+        $this->assertEquals('27777.78 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(2));
+    }
+
+    public function testFromMilesPerSecond()
+    {
+        $volumeUnit = new Velocity\MilePerSecond(100000);
+        $this->assertEquals('160934400.00 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(2));
+    }
+
+    public function testFromInchPerHour()
+    {
+        $volumeUnit = new Velocity\InchPerHour(100000);
+        $this->assertEquals('0.706 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(3));
+    }
+
+    public function testFromInchPerMinute()
+    {
+        $volumeUnit = new Velocity\InchPerMinute(100000);
+        $this->assertEquals('42.333 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(3));
+    }
+
+    public function testFromInchPerSecond()
+    {
+        $volumeUnit = new Velocity\InchPerSecond(100000);
+        $this->assertEquals('2540.00 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(2));
+    }
+
+    public function testFromKnot()
+    {
+        $volumeUnit = new Velocity\Knot(100000);
+        $this->assertEquals('51444 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(0));
+    }
+
+    public function testFromMilesPerMinute()
+    {
+        $volumeUnit = new Velocity\MilePerMinute(100000);
+        $this->assertEquals('2682240.00 m/s', Velocity\MeterPerSecond::from($volumeUnit)->format(2));
+    }
+}
diff --git a/tests/UnitTest.php b/tests/UnitTest.php
@@ -62,7 +62,7 @@ public function testTypeUnits()
             count($allUnits),
             $this->logicalOr(
                 $this->equalTo(9),
-                $this->equalTo(232)
+                $this->equalTo(247)
             )
         );
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.idea/`
`1`	`2`	`.git`
`2`	`3`	`clover.xml`
`3`	`4`	`coveralls-upload.json`