Merge pull request #1033 from Daft-Freak/patch-1

Gadgetoid · web-flow · commit 17d180dd3746 · 2024-12-04T16:56:28.000Z
hub75: don't enable an unrelated IRQ
diff --git a/drivers/hub75/hub75.cpp b/drivers/hub75/hub75.cpp
@@ -146,7 +146,6 @@ void Hub75::start(irq_handler_t handler) {
 
         dma_channel_set_irq0_enabled(dma_channel, true);
 
-        irq_set_enabled(pio_get_dreq(pio, sm_data, true), true);
         irq_set_enabled(DMA_IRQ_0, true);
 
         row = 0;
@@ -161,7 +160,6 @@ void Hub75::start(irq_handler_t handler) {
 void Hub75::stop(irq_handler_t handler) {
 
     irq_set_enabled(DMA_IRQ_0, false);
-    irq_set_enabled(pio_get_dreq(pio, sm_data, true), false);
 
     if(dma_channel != -1 &&  dma_channel_is_claimed(dma_channel)) {
         dma_channel_set_irq0_enabled(dma_channel, false);
@@ -275,4 +273,4 @@ void Hub75::update(PicoGraphics *graphics) {
         }
     }
 }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,6 @@ void Hub75::start(irq_handler_t handler) {`
`146`	`146`
`147`	`147`	`dma_channel_set_irq0_enabled(dma_channel, true);`
`148`	`148`
`149`		`- irq_set_enabled(pio_get_dreq(pio, sm_data, true), true);`
`150`	`149`	`irq_set_enabled(DMA_IRQ_0, true);`
`151`	`150`
`152`	`151`	`row = 0;`
`@@ -161,7 +160,6 @@ void Hub75::start(irq_handler_t handler) {`
`161`	`160`	`void Hub75::stop(irq_handler_t handler) {`
`162`	`161`
`163`	`162`	`irq_set_enabled(DMA_IRQ_0, false);`
`164`		`- irq_set_enabled(pio_get_dreq(pio, sm_data, true), false);`
`165`	`163`
`166`	`164`	`if(dma_channel != -1 && dma_channel_is_claimed(dma_channel)) {`
`167`	`165`	`dma_channel_set_irq0_enabled(dma_channel, false);`
`@@ -275,4 +273,4 @@ void Hub75::update(PicoGraphics *graphics) {`
`275`	`273`	`}`
`276`	`274`	`}`
`277`	`275`	`}`
`278`		`-}`
	`276`	`+}`