Merge pull request #862 from pimoroni/patch-polygon-clip

Gadgetoid · web-flow · commit b4451c3bdc06 · 2023-10-16T10:46:58.000+01:00
Pico Graphics: Avoid unecessary and broken polygon scanline clip.
diff --git a/libraries/pico_graphics/pico_graphics.cpp b/libraries/pico_graphics/pico_graphics.cpp
@@ -268,7 +268,7 @@ namespace pimoroni {
           int32_t ex = points[j].x;
           int32_t px = int32_t(sx + float(fy - sy) / float(ey - sy) * float(ex - sx));
 
-          nodes[n++] = px < clip.x ? clip.x : (px >= clip.x + clip.w ? clip.x + clip.w - 1 : px);// clamp(int32_t(sx + float(fy - sy) / float(ey - sy) * float(ex - sx)), clip.x, clip.x + clip.w);
+          nodes[n++] = px;
         }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ namespace pimoroni {`
`268`	`268`	`int32_t ex = points[j].x;`
`269`	`269`	`int32_t px = int32_t(sx + float(fy - sy) / float(ey - sy) * float(ex - sx));`
`270`	`270`
`271`		`- nodes[n++] = px < clip.x ? clip.x : (px >= clip.x + clip.w ? clip.x + clip.w - 1 : px);// clamp(int32_t(sx + float(fy - sy) / float(ey - sy) * float(ex - sx)), clip.x, clip.x + clip.w);`
	`271`	`+ nodes[n++] = px;`
`272`	`272`	`}`
`273`	`273`	`}`
`274`	`274`