QA: Add more checks, fix the fallout.

Author: Gadgetoid

ci/python.sh

@@ -1,5 +1,19 @@
-QA_INCLUDE="F,Q,W,E,B"
-QA_IGNORE="E501,E402"
+# F = Pyflakes
+# Q = Quotes
+# E/W = pycodestyle (Whitespace, Line lengths etc)
+# B - flake8-bugbear = Unused loop variables, sloppy code
+# COM - flake8-commas
+# BLE - flake8-blind-except
+# C4  - flake8-comprehensions
+# ISC - flake8-implicit-str-concat = Implicit string concat, eg: `"hello" "world"` on one line
+# ICN - flake8-import-conventions = Import conventions
+# PIE - flake8-pie = Misc silliness, catches range with a 0 start argument
+# RET - flake8-return = Enforces straight-forward code around return statements
+# SLF - flake8-self
+# ARG - flake8-unused-arguments
+
+QA_INCLUDE="F,Q,W,E,B,COM,BLE,C4,ISC,ICN,PIE,RSE,RET,SLF,ARG"
+QA_IGNORE="E501,E402,COM812"
 
 function qa_prepare_all {
     pip install ruff

examples/balls_demo.py

@@ -23,7 +23,7 @@ def __init__(self, x, y, r, dx, dy, pen):
 
 # initialise shapes
 balls = []
-for _ in range(0, 170):
+for _ in range(170):
     r = random.randint(0, 10) + 3
     balls.append(
         Ball(

examples/cheerlights_bulb.py

@@ -206,9 +206,7 @@ def get_cheerlight():
         req.close()
         print("Success!")
 
-        colour = tuple(int(json["field2"][i:i + 2], 16) for i in (1, 3, 5))
-
-        return colour
+        return tuple(int(json["field2"][i:i + 2], 16) for i in (1, 3, 5))
 
     except OSError:
         print("Error: Failed to get new colour")

examples/image_gallery.py

@@ -95,7 +95,7 @@ def numberedfiles(k):
 
 
 try:
-    files = list(file for file in sorted(os.listdir(directory), key=numberedfiles) if file.endswith(".jpg"))
+    files = [file for file in sorted(os.listdir(directory), key=numberedfiles) if file.endswith(".jpg")]
 except OSError:
     display_error("Problem loading images.\n\nEnsure that your Presto or SD card contains a 'gallery' folder in the root")
 

examples/random_maze.py

@@ -151,20 +151,20 @@ def build(self, width, height):
         self.maze = []
 
         row = [1]
-        for _ in range(0, self.width):
+        for _ in range(self.width):
             row.append(1)
             row.append(1)
         self.maze.append(row)
 
-        for y in range(0, self.height):
+        for y in range(self.height):
             row = [1]
-            for x in range(0, self.width):
+            for x in range(self.width):
                 row.append(0)
                 row.append(1 if self.cell_grid[x][y].right else 0)
             self.maze.append(row)
 
             row = [1]
-            for x in range(0, self.width):
+            for x in range(self.width):
                 row.append(1 if self.cell_grid[x][y].bottom else 0)
                 row.append(1)
             self.maze.append(row)

examples/word_clock.py

@@ -66,16 +66,20 @@ def approx_time(hours, minutes):
 
     if hours == 12:
         hours = 0
+
     if minutes > 0 and minutes < 8:
         return "it is about " + nums[hours] + " O'Clock"
-    elif minutes >= 8 and minutes < 23:
+
+    if minutes >= 8 and minutes < 23:
         return "it is about quarter past " + nums[hours]
-    elif minutes >= 23 and minutes < 38:
+
+    if minutes >= 23 and minutes < 38:
         return "it is about half past " + nums[hours]
-    elif minutes >= 38 and minutes < 53:
+
+    if minutes >= 38 and minutes < 53:
         return "it is about quarter to " + nums[hours + 1]
-    else:
-        return "it is about " + nums[hours + 1] + " O'Clock"
+
+    return "it is about " + nums[hours + 1] + " O'Clock"
 
 
 def update():