Skip to content

Commit 50889d5

Browse files
committed
Changes suggested for pull request.
1 parent 8c13697 commit 50889d5

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

Makefile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ BASH_COMPLETION_DIR := $(strip $(BASH_COMPLETION_DIR))
55
USERDIR ?= $(HOME)
66

77
# The @ symbols make the output silent.
8-
# the \033[0m stuff is ansi color escape codes.
98

109
install:
1110
@if [ -d $(BASH_COMPLETION_DIR) ]; then \
@@ -19,13 +18,13 @@ install:
1918
@install -m755 -D notes $(PREFIX)/bin/notes
2019
@install -m777 -D config $(USERDIR)/.config/notes/config
2120
@install -D notes.1 $(PREFIX)/share/man/man1/notes.1
22-
@mandb 1>/dev/nulli 2>&1 # Fail silently if we don't have a mandb
23-
@echo -e "Notes has been installed to \033[0;32m$(PREFIX)/bin/notes." \
24-
"\n\033[0mA configuration file has also been created at" \
25-
"\033[0;32m$(USERDIR)/.config/notes/config,\033[0m" \
21+
@mandb 1>/dev/null 2>&1 # Fail silently if we don't have a mandb
22+
@echo -e "Notes has been installed to $(PREFIX)/bin/notes." \
23+
"A configuration file has also been created at" \
24+
"$(USERDIR)/.config/notes/config," \
2625
"which you can edit if you'd like to change the default settings." \
27-
"\nGet started now by running \033[0;32mnotes open my-new-note\033[0m" \
28-
"Or you can run \033[0;32mnotes help\033[0m for more info"
26+
"\nGet started now by running notes open my-new-note" \
27+
"Or you can run notes help for more info"
2928

3029
uninstall:
3130
rm -f $(PREFIX)/bin/notes

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ You'll need to open a new shell for this to take effect.
5555
## What if I want to uninstall this?
5656
If you used the automated install script to install notes, you can uninstall it the same way by running:
5757
```bash
58-
export uninstall=1 && curl https://rawgit.com/pimterry/notes/master/install.sh | bash
58+
curl https://rawgit.com/pimterry/notes/master/install.sh | bash -s uninstall
5959
```
6060

6161
## How do I configure this?

install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ extract_dir=$(mktemp -d /tmp/notes.XXXXX)
2525

2626
echo "Downloading and Extracting Notes from Repository..."
2727
curl -L https://api.github.com/repos/pimterry/notes/tarball | tar -xzp -C $extract_dir --strip-components=1
28-
if [ "$uninstall" != "1" ]; then
28+
if [ "$1" != "uninstall" ]; then
2929
echo "Installing notes..."
3030
cd $extract_dir && make USERDIR=$user_home
3131
else

0 commit comments

Comments
 (0)