Make sure we get the right error if no editor is available

Author: pimterry

notes

@@ -1,11 +1,14 @@
 #!/bin/bash
 
-EDITOR=${EDITOR:-editor}
-
 configured_dir=${NOTES_DIRECTORY%/} # Remove trailing slashes
 notes_dir="${configured_dir:-$HOME/notes}"
 escaped_notes_dir=$(printf $notes_dir | sed -e 's/[]\/$*.^|[]/\\&/g')
 
+# If no $EDITOR, look for `editor` (symlink on debian/ubuntu/etc)
+if [ -z $EDITOR ] && type editor &>/dev/null; then
+    EDITOR=editor
+fi
+
 without_notes_dir() {
     cat | sed -e s/^$escaped_notes_dir//g | sed -E "s/^\/+//g" 
 }

test/test-open.bats

@@ -34,6 +34,7 @@ notes="./notes"
   run $notes open test
 
   assert_failure
+  assert_output "Please set \$EDITOR to edit notes"
 }
 
 @test "Opens the configured notes directory if set" {