Use is to compare types

Author: WhyNotHugo

khal/icalendar.py

@@ -289,10 +289,10 @@ def sanitize_datetime(date: dt.date) -> dt.date:
             # rrule._until and dtstart could be dt.date or dt.datetime. They
             # need to be the same for comparison
             testuntil = rrule._until  # type: ignore
-            if (type(dtstart) == dt.date and type(testuntil) == dt.datetime):
+            if (type(dtstart) is dt.date and type(testuntil) is dt.datetime):
                 testuntil = testuntil.date()
             teststart = dtstart
-            if (type(testuntil) == dt.date and type(teststart) == dt.datetime):
+            if (type(testuntil) is dt.date and type(teststart) is dt.datetime):
                 teststart = teststart.date()
 
             if testuntil < teststart:
@@ -430,7 +430,7 @@ def sanitize_timerange(dtstart, dtend, duration=None):
                 "Assuming it's the same timezone as the end time"
             )
             dtstart = dtend.tzinfo.localize(dtstart)
-    if dtend is not None and type(dtstart) != type(dtend):
+    if dtend is not None and type(dtstart) is not type(dtend):
         raise ValueError(
             'The event\'s end time (DTEND) and start time (DTSTART) are not of the same type.')
 

khal/khalendar/event.py

@@ -211,7 +211,7 @@ def update_start_end(self, start: dt.datetime, end: dt.datetime) -> None:
 
         beware, this methods performs some open heart surgery
         """
-        if type(start) != type(end):
+        if type(start) is not type(end):
             raise ValueError('DTSTART and DTEND should be of the same type (datetime or date)')
         self.__class__ = self._get_type_from_date(start)
 

tests/event_test.py

@@ -413,7 +413,7 @@ def test_event_raw_UTC():
 def test_zulu_events():
     """test if events in Zulu time are correctly recognized as localized events"""
     event = Event.fromString(_get_text('event_dt_simple_zulu'), **EVENT_KWARGS)
-    assert type(event) == LocalizedEvent
+    assert type(event) is LocalizedEvent
     assert event.start_local == BERLIN.localize(dt.datetime(2014, 4, 9, 11, 30))
 
 
@@ -451,9 +451,9 @@ def test_recur():
 
 def test_type_inference():
     event = Event.fromString(_get_text('event_dt_simple'), **EVENT_KWARGS)
-    assert type(event) == LocalizedEvent
+    assert type(event) is LocalizedEvent
     event = Event.fromString(_get_text('event_dt_simple_zulu'), **EVENT_KWARGS)
-    assert type(event) == LocalizedEvent
+    assert type(event) is LocalizedEvent
 
 
 def test_duplicate_event():