Merge pull request #906 from pimutils/async

Initial asyncio support

Author: Hugo Osvaldo Barrera

.builds/archlinux.yaml

@@ -14,11 +14,16 @@ packages:
   - python-click-threading
   - python-requests
   - python-requests-toolbelt
+  - python-aiohttp-oauthlib
   # Test dependencies:
   - python-hypothesis
   - python-pytest-cov
   - python-pytest-httpserver
   - python-trustme
+  - python-pytest-asyncio
+  - python-aiohttp
+  - python-aiostream
+  - python-aioresponses
 sources:
   - https://github.com/pimutils/vdirsyncer
 environment:

CHANGELOG.rst

@@ -15,12 +15,20 @@ Version 0.19.0
 - Add "description" and "order" as metadata.  These fetch the CalDAV:
   calendar-description, CardDAV:addressbook-description and apple-ns:calendar-order
   properties.
-- Add a new "showconfig" status. This prints *some* configuration values as
+- Add a new ``showconfig`` status. This prints *some* configuration values as
   JSON. This is intended to be used by external tools and helpers that interact
   with ``vdirsyncer``.
-- Update TLS-related tests that were failing due to weak MDs.
+- Update TLS-related tests that were failing due to weak MDs. :gh:`903`
 - ``pytest-httpserver`` and ``trustme`` are now required for tests.
 - ``pytest-localserver`` is no longer required for tests.
+- Multithreaded support has been dropped. The ``"--max-workers`` has been removed.
+- A new ``asyncio`` backend is now used. So far, this shows substantial speed
+  improvements in ``discovery`` and ``metasync``, but little change in `sync`.
+  This will likely continue improving over time. :gh:`906`
+- Support for `md5` and `sha1` certificate fingerprints has been dropped. If
+  you're validating certificate fingerprints, use `sha256` instead.
+- The ``google`` storage types no longer require ``requests-oauthlib``, but
+  require ``python-aiohttp-oauthlib`` instead.
 
 Version 0.18.0
 ==============

setup.cfg

@@ -8,6 +8,7 @@ addopts =
   --cov=vdirsyncer
   --cov-report=term-missing
   --no-cov-on-fail
+# filterwarnings=error
 
 [flake8]
 application-import-names = tests,vdirsyncer

setup.py

@@ -13,14 +13,14 @@
     # https://github.com/mitsuhiko/click/issues/200
     "click>=5.0,<9.0",
     "click-log>=0.3.0, <0.4.0",
-    # https://github.com/pimutils/vdirsyncer/issues/478
-    "click-threading>=0.5",
     "requests >=2.20.0",
     # https://github.com/sigmavirus24/requests-toolbelt/pull/28
     # And https://github.com/sigmavirus24/requests-toolbelt/issues/54
     "requests_toolbelt >=0.4.0",
     # https://github.com/untitaker/python-atomicwrites/commit/4d12f23227b6a944ab1d99c507a69fdbc7c9ed6d  # noqa
     "atomicwrites>=0.1.7",
+    "aiohttp>=3.7.1,<4.0.0",
+    "aiostream>=0.4.3,<0.5.0",
 ]
 
 
@@ -56,7 +56,7 @@ def run(self):
     install_requires=requirements,
     # Optional dependencies
     extras_require={
-        "google": ["requests-oauthlib"],
+        "google": ["aiohttp-oauthlib"],
         "etesync": ["etesync==0.5.2", "django<2.0"],
     },
     # Build dependencies

test-requirements.txt

@@ -3,3 +3,5 @@ pytest
 pytest-cov
 pytest-httpserver
 trustme
+pytest-asyncio
+aioresponses

tests/conftest.py

@@ -4,6 +4,7 @@
 import logging
 import os
 
+import aiohttp
 import click_log
 import pytest
 from hypothesis import HealthCheck
@@ -52,3 +53,18 @@ def benchmark():
     settings.load_profile("ci")
 else:
     settings.load_profile("dev")
+
+
+@pytest.fixture
+async def aio_session(event_loop):
+    async with aiohttp.ClientSession() as session:
+        yield session
+
+
+@pytest.fixture
+async def aio_connector(event_loop):
+    conn = aiohttp.TCPConnector(limit_per_host=16)
+    try:
+        yield conn
+    finally:
+        await conn.close()