Some code simplifications with the return statement #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
reviewed
Apr 7, 2021
WhyNotHugo
force-pushed
the
simplify_return
branch
3 times, most recently
from
1cf6287 to
141623c
Compare
|
Rebased and applied. Thanks. |
dilyanpalauzov
commented
Aug 29, 2025
| @@ -59,21 +59,20 @@ async def collections_for_pair( | |||
| cache_key = _get_collections_cache_key(pair) | |||
| if from_cache: | |||
| rv = load_status(status_path, pair.name, data_type="collections") | |||
| if rv.get("cache_key", None) == cache_key: | |||
| if rv and rv.get("cache_key", None) == cache_key: | |||
There was a problem hiding this comment.
Is this change form me and is it necessary? The other changes here do not modify the program logic, that is they preserve all the bugs. But this change modifies the program logic.
There was a problem hiding this comment.
This change was from your original commit.
When I reviewed this earlier the change made sense to me because of the following elif rv. I realise now that it is unnecessary. It should not change the logic, assuming that rv is never None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.