You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix "pip" collision in workflow script causing normal cells to be filtered out (#489)
## Problem
Describe the purpose of this change. What problem is being solved and
why?
The convert-notebook script, used in the test notebooks action was
failing notebooks that should pass under normal circumstances. The issue
was a line in the workflow script that filtered out cells containing the
string "pip", which filtered out "pipeline", "pipe", etc. This can be
seen in the following prs:
Instance 1: "pipeline" getting filtered out:
#474
Instance 2: "pipe" getting filtered out:
https://github.com/pinecone-io/examples/actions/runs/16154448867/job/45593572999?pr=473
## Solution
Describe the approach you took. Link to any relevant bugs, issues, docs,
or other resources.
I added a list of pip commands we'd want to ignore at the relevant level
of preprocessing and had the script filter cells with those out, instead
of "pip"
## Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)
## Test Plan
Describe specific steps for validating this change.
I'll re-run tests that failed with the old script.
0 commit comments