Commit 4e7a6df
committed
fix(theme): stop inverting the home branding in dark mode
The previous commit made the home logo's fill theme-driven (`currentColor` +
`text-primary`) but left the pre-existing `dark:invert` in place. A CSS filter
does not care where the colour came from, so in dark mode a deployer's
configured primary is painted as its complement - with `primary: '#2dd4bf'` the
logo renders red - which defeats the customisation this PR documents. Thanks
@chatgpt-codex-connector for catching it.
The adjacent `<h1>` is included even though this PR did not introduce it: the two
are siblings in the same hero lockup and carry the same `text-primary
dark:invert`, so removing the inversion from only the logo would leave the mark
and the wordmark in complementary colours next to each other.
Verified with the reviewer's example value: both now compute rgb(43, 212, 189)
with `filter: none`, matching the configured #2dd4bf, where before the filter
painted them rgb(212, 43, 66).
Note this leaves ~30 other `text-primary dark:invert` pairs elsewhere in the
codebase untouched. They predate this PR and have the same conflict with a
customised theme, but they are outside the branding this change concerns.1 parent 80fc1f2 commit 4e7a6df
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments