Skip to content

Conversation

@lcwangchao
Copy link
Contributor

@lcwangchao lcwangchao commented Sep 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2025
@lcwangchao lcwangchao force-pushed the indexlookuppushdown branch 2 times, most recently from 4cb72e7 to 76da657 Compare September 25, 2025 02:15
@qiancai qiancai added v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 25, 2025
@lcwangchao lcwangchao force-pushed the indexlookuppushdown branch 2 times, most recently from 476f9c7 to 3fc2a72 Compare September 25, 2025 04:33
@Oreoxmt Oreoxmt self-requested a review September 28, 2025 06:58
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 17, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 17, 2025

@lcwangchao Could you please invite a tech reviewer? Thanks!

@lcwangchao lcwangchao requested a review from cfzjywxk December 17, 2025 09:40
@lcwangchao
Copy link
Contributor Author

@cfzjywxk PTAL

@lcwangchao
Copy link
Contributor Author

@zhaoshangzi PTAL

@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 19, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2025

@zhaoshangzi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 23, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2025
@Oreoxmt Oreoxmt requested a review from qiancai December 26, 2025 00:48
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 07:13:44.924343751 +0000 UTC m=+1629969.738121313: ☑️ agreed by Oreoxmt.
  • 2025-12-29 02:53:52.510787288 +0000 UTC m=+2651177.324564860: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 31, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 31, 2025

/unhold

@ti-chi-bot ti-chi-bot bot added approved and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 31, 2025
@ti-chi-bot ti-chi-bot bot merged commit b386123 into master Dec 31, 2025
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the indexlookuppushdown branch December 31, 2025 06:28
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants