Add generate-next-gen-grafana to check target and improve sed compatibility (#3191)

close #3047

Author: tenfyzhong

Makefile

@@ -322,7 +322,7 @@ check-makefiles: format-makefiles
 format-makefiles: $(MAKE_FILES)
 	$(SED_IN_PLACE) -e 's/^\(\t*\)  /\1\t/g' -e 's/^\(\t*\) /\1/' -- $?
 
-check: check-copyright fmt tidy generate_mock go-generate check-diff-line-width check-ticdc-dashboard check-makefiles
+check: check-copyright fmt tidy generate_mock go-generate check-diff-line-width check-ticdc-dashboard check-makefiles generate-next-gen-grafana
 	@git --no-pager diff --exit-code || (echo "Please add changed files!" && false)
 
 clean:

metrics/grafana/ticdc_new_arch.json

@@ -22192,5 +22192,5 @@
   "timezone": "browser",
   "title": "Test-Cluster-TiCDC-New-Arch",
   "uid": "YiGL8hBZ0aac",
-  "version": 11
+  "version": 12
 }

metrics/grafana/ticdc_new_arch_next_gen.json

@@ -8951,9 +8951,9 @@
           "targets": [
             {
               "exemplar": true,
-              "expr": "sum(rate(ticdc_event_store_scan_bytes{k8s_cluster=\"$k8s_cluster\", sharedpool_id=\"$tidb_cluster\", instance=~\"$ticdc_instance\"}[1m])) by (instance)",
+              "expr": "sum(rate(ticdc_event_store_scan_bytes{k8s_cluster=\"$k8s_cluster\", sharedpool_id=\"$tidb_cluster\", instance=~\"$ticdc_instance\"}[1m])) by (instance, type)",
               "interval": "",
-              "legendFormat": "{{instance}}",
+              "legendFormat": "{{instance}}-{{type}}",
               "queryType": "randomWalk",
               "refId": "A"
             }

metrics/grafana/ticdc_new_arch_with_keyspace_name.json

@@ -8563,5 +8563,5 @@
   "timezone": "browser",
   "title": "Test-Cluster-TiCDC-New-Arch-KeyspaceName",
   "uid": "lGT5hED6vqTn",
-  "version": 11
+  "version": 12
 }

scripts/generate-next-gen-metrics.sh

@@ -19,7 +19,19 @@ ORIGIN_FILE="metrics/grafana/ticdc_new_arch.json"
 NEXT_GEN_SHARED_FILE="${1:-metrics/grafana/ticdc_new_arch_next_gen.json}"
 NEXT_GEN_USER_FILE="${2:-metrics/grafana/ticdc_new_arch_with_keyspace_name.json}"
 
-sed 's/namespace/keyspace_name/g;' $ORIGIN_FILE >"$NEXT_GEN_SHARED_FILE"
+# Detect the appropriate sed command
+SED_CMD=""
+if command -v gsed &>/dev/null; then
+	SED_CMD="gsed"
+elif [[ $(sed --version 2>/dev/null) == *"GNU"* ]]; then
+	SED_CMD="sed"
+else
+	echo "This script requires GNU sed." >&2
+	echo "On macOS, you can install it with 'brew install gnu-sed' and use it as 'gsed'." >&2
+	exit 1
+fi
+
+"$SED_CMD" 's/namespace/keyspace_name/g;' $ORIGIN_FILE >"$NEXT_GEN_SHARED_FILE"
 
 if ! command -v jq &>/dev/null; then
 	echo "Error: jq is not installed. Please install it to run this script." >&2
@@ -57,7 +69,7 @@ sed -i "s/YiGL8hBZ0aac/lGT5hED6vqTn/" "$NEXT_GEN_USER_FILE"
 
 echo "Userscope dashboard created at '$NEXT_GEN_USER_FILE'"
 
-sed -i 's/tidb_cluster_id/tidb_cluster/' "$NEXT_GEN_SHARED_FILE"
-sed -i 's/tidb_cluster/sharedpool_id/' "$NEXT_GEN_SHARED_FILE"
+"$SED_CMD" -i 's/tidb_cluster_id/tidb_cluster/' "$NEXT_GEN_SHARED_FILE"
+"$SED_CMD" -i 's/tidb_cluster/sharedpool_id/' "$NEXT_GEN_SHARED_FILE"
 
 echo "Sharedscope dashboard created at '$NEXT_GEN_SHARED_FILE'"