Skip to content

Commit b9f40d0

Browse files
committed
fix(log): change filter dml logs to debug level (#3327)
close #3326
1 parent 4863649 commit b9f40d0

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

logservice/schemastore/persist_storage_ddl_handlers.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1645,7 +1645,6 @@ func buildDDLEventCommonWithTableID(rawEvent *PersistedDDLEvent, tableID int64,
16451645
zap.String("table", rawEvent.TableName),
16461646
zap.String("extraTable", rawEvent.ExtraTableName),
16471647
zap.String("query", rawEvent.Query),
1648-
zap.Any("tableInfo", rawEvent.TableInfo),
16491648
zap.Any("ddlType", model.ActionType(rawEvent.Type)),
16501649
zap.Uint64("startTs", rawEvent.StartTs),
16511650
)
@@ -1657,7 +1656,6 @@ func buildDDLEventCommonWithTableID(rawEvent *PersistedDDLEvent, tableID int64,
16571656
zap.String("table", rawEvent.TableName),
16581657
zap.String("extraTable", rawEvent.ExtraTableName),
16591658
zap.String("query", rawEvent.Query),
1660-
zap.Any("tableInfo", rawEvent.TableInfo),
16611659
zap.Any("ddlType", model.ActionType(rawEvent.Type)),
16621660
zap.Uint64("startTs", rawEvent.StartTs),
16631661
)
@@ -2617,9 +2615,7 @@ func buildDDLEventForCreateTables(rawEvent *PersistedDDLEvent, tableFilter filte
26172615
return commonEvent.DDLEvent{}, false, err
26182616
}
26192617
if filtered {
2620-
log.Info("build ddl event for create tables filter table",
2621-
zap.String("schemaName", rawEvent.SchemaName),
2622-
zap.String("tableName", info.Name.O))
2618+
log.Info("discard DDL by filter in create tables", zap.String("schemaName", rawEvent.SchemaName), zap.String("tableName", info.Name.O))
26232619
continue
26242620
}
26252621
}

pkg/common/event/dml_event.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ func (t *DMLEvent) AppendRow(raw *common.RawKVEntry,
542542
return errors.Trace(err)
543543
}
544544
if skip {
545-
log.Info("ignore DML by filter", zap.Any("tableInfo", t.TableInfo), zap.Any("raw", raw))
545+
log.Debug("ignore DML by filter", zap.Any("tableInfo", t.TableInfo), zap.Any("raw", raw))
546546
t.Rows.TruncateTo(t.Rows.NumRows() - count) // Remove the rows that were added
547547
return nil
548548
}

0 commit comments

Comments
 (0)