build: add new task for integration tests of sync_diff_inspector (#12060)

ref #11672

Author: joechenrh

Makefile

@@ -388,6 +388,17 @@ clean:
 sync-diff-inspector:
 	$(GOBUILD) -ldflags '$(LDFLAGS)' -o bin/sync_diff_inspector ./sync_diff_inspector
 
+sync-diff-inspector-integration_test: failpoint-enable sync-diff-inspector failpoint-disable
+	@which bin/tidb-server
+	@which bin/tikv-server
+	@which bin/pd-server
+	@which bin/sync_diff_inspector
+	@which bin/dumpling
+	@which bin/loader
+	@which bin/importer
+	cd sync_diff_inspector && ln -sf ../bin .
+	cd sync_diff_inspector && ./tests/run.sh
+
 dm: dm-master dm-worker dmctl dm-syncer
 
 dm-master:

dm/pkg/shardddl/optimism/lock_test.go

@@ -2738,7 +2738,7 @@ func (t *testLock) TestTrySyncForOneDDL(c *check.C) {
 	c.Assert(schemaChanged, check.IsTrue)
 	c.Assert(conflictStage, check.Equals, ConflictNone)
 
-	// check create partition, no changed since https://github.com/pingcap/tidb-tools/blob/d671b0840063bc2532941f02e02e12627402844c/pkg/schemacmp/table.go#L251
+	// check create partition, no changed since https://github.com/pingcap/tidb/blob/42075e6ad60ba5d1f860ac845908f0c34ac28253/pkg/util/schemacmp/table.go#L256
 	schemaChanged, conflictStage = l.trySyncForOneDDL(source, schema, table1, t0, t1)
 	c.Assert(schemaChanged, check.IsTrue)
 	c.Assert(conflictStage, check.Equals, ConflictNone)

dm/syncer/validate_worker.go

@@ -476,7 +476,7 @@ type validateCompareContext struct {
 	columns     []*model.ColumnInfo
 }
 
-// a simplified version of https://github.com/pingcap/tidb-tools/blob/d9fdfa2f9040aab3fab7cd11774a82226f467fe7/sync_diff_inspector/utils/utils.go#L487-L606
+// a simplified version of CompareData in https://github.com/pingcap/tiflow/blob/4c38b919659e8506c220d1be9b0fdd7baf609e33/sync_diff_inspector/utils/utils.go#L538
 func (c *validateCompareContext) compareData(key string, sourceData, targetData []*sql.NullString) (bool, error) {
 	for i, column := range c.columns {
 		data1, data2 := sourceData[i], targetData[i]

sync_diff_inspector/tests/README.md

@@ -21,7 +21,7 @@ This folder contains all tests which relies on external service such as TiDB.
 
 3. The user executing the tests must have permission to create the folder
 
-   `/tmp/tidb_tools_test`. All test artifacts will be written into this folder.
+   `/tmp/sync_diff_inspector_test`. All test artifacts will be written into this folder.
 
 ## Running
 

sync_diff_inspector/tests/_utils/check_contains

@@ -4,7 +4,7 @@
 # argument 2 is the filename
 
 set -eu
-OUT_DIR=/tmp/tidb_tools_test
+OUT_DIR=/tmp/sync_diff_inspector_test
 
 if ! grep -Fq "$1" "$2"; then
 	echo "TEST FAILED: '$2' DOES NOT CONTAIN '$1'"

sync_diff_inspector/tests/_utils/check_contains_count

@@ -5,7 +5,7 @@
 # argument 3 is the match count
 
 set -eu
-OUT_DIR=/tmp/tidb_tools_test
+OUT_DIR=/tmp/sync_diff_inspector_test
 
 count=$(grep -F "$1" "$2" | wc -l)
 

sync_diff_inspector/tests/_utils/check_contains_regex

@@ -4,7 +4,7 @@
 # argument 2 is the filename
 
 set -eu
-OUT_DIR=/tmp/tidb_tools_test
+OUT_DIR=/tmp/sync_diff_inspector_test
 
 if ! grep -q "$1" "$2"; then
 	echo "TEST FAILED: '$2' DOES NOT CONTAIN '$1'"

sync_diff_inspector/tests/run.sh

@@ -2,7 +2,7 @@
 
 set -eu
 
-OUT_DIR=/tmp/tidb_tools_test
+OUT_DIR=/tmp/sync_diff_inspector_test
 
 # assign default value to mysql config
 if [[ -z ${MYSQL_HOST+x} ]]; then

sync_diff_inspector/tests/sync_diff_inspector/checkpoint/config_base.toml

@@ -40,7 +40,7 @@ chunk-size = 10
     # 2 log: sync-diff.log
     # 3 summary: summary.txt
     # 4 checkpoint: a dir
-    output-dir = "/tmp/tidb_tools_test/sync_diff_inspector/output"
+    output-dir = "/tmp/sync_diff_inspector_test/sync_diff_inspector/output"
 
     source-instances = ["mysql1"]
 

sync_diff_inspector/tests/sync_diff_inspector/checkpoint/config_base_continous.toml

@@ -42,7 +42,7 @@ chunk-size = 50
     # 2 log: sync-diff.log
     # 3 summary: summary.txt
     # 4 checkpoint: a dir
-    output-dir = "/tmp/tidb_tools_test/sync_diff_inspector/output"
+    output-dir = "/tmp/sync_diff_inspector_test/sync_diff_inspector/output"
 
     source-instances = ["mysql1"]