manager: add a limit to the capture and replay job history (#695)

Author: djshow832

pkg/sqlreplay/manager/manager.go

@@ -18,6 +18,10 @@ import (
 	"go.uber.org/zap"
 )
 
+const (
+	maxJobHistoryCount = 10
+)
+
 type CertManager interface {
 	SQLTLS() *tls.Config
 }
@@ -99,7 +103,7 @@ func (jm *jobManager) StartCapture(cfg capture.CaptureConfig) error {
 		cfg: cfg,
 	}
 	jm.lg.Info("start capture", zap.String("job", newJob.String()))
-	jm.jobHistory = append(jm.jobHistory, newJob)
+	jm.addToHistory(newJob)
 	return nil
 }
 
@@ -127,10 +131,19 @@ func (jm *jobManager) StartReplay(cfg replay.ReplayConfig) error {
 		cfg: cfg,
 	}
 	jm.lg.Info("start replay", zap.String("job", newJob.String()))
-	jm.jobHistory = append(jm.jobHistory, newJob)
+	jm.addToHistory(newJob)
 	return nil
 }
 
+func (jm *jobManager) addToHistory(newJob Job) {
+	if len(jm.jobHistory) >= maxJobHistoryCount {
+		copy(jm.jobHistory, jm.jobHistory[1:])
+		jm.jobHistory[len(jm.jobHistory)-1] = newJob
+	} else {
+		jm.jobHistory = append(jm.jobHistory, newJob)
+	}
+}
+
 func (jm *jobManager) GetCapture() capture.Capture {
 	return jm.capture
 }

pkg/sqlreplay/manager/manager_test.go

@@ -131,3 +131,21 @@ func TestMarshalJobHistory(t *testing.T) {
   }
 ]`, mgr.Jobs())
 }
+
+func TestHistoryLen(t *testing.T) {
+	mgr := NewJobManager(zap.NewNop(), &config.Config{}, &mockCertMgr{}, nil, nil)
+	defer mgr.Close()
+	cpt, rep := &mockCapture{}, &mockReplay{}
+	mgr.capture, mgr.replay = cpt, rep
+	require.Len(t, mgr.jobHistory, 0)
+
+	for i := 0; i < maxJobHistoryCount+1; i++ {
+		require.NoError(t, mgr.StartCapture(capture.CaptureConfig{}))
+		require.Contains(t, mgr.Stop(), "stopped")
+		expectedLen := i + 1
+		if expectedLen > maxJobHistoryCount {
+			expectedLen = maxJobHistoryCount
+		}
+		require.Len(t, mgr.jobHistory, expectedLen)
+	}
+}