sqlreplay: fix replay reports invalid encryption key length (#755)

Author: djshow832

pkg/sqlreplay/replay/replay.go

@@ -159,7 +159,7 @@ func (r *replay) Start(cfg ReplayConfig, backendTLSConfig *tls.Config, hsHandler
 	if err != nil {
 		return errors.Wrapf(err, "failed to load encryption key")
 	}
-	cfg.encryptionKey = key
+	r.cfg.encryptionKey = key
 
 	hsHandler = NewHandshakeHandler(hsHandler)
 	r.connCreator = cfg.connCreator

pkg/sqlreplay/replay/replay_test.go

@@ -4,6 +4,8 @@
 package replay
 
 import (
+	"os"
+	"path/filepath"
 	"reflect"
 	"testing"
 	"time"
@@ -274,21 +276,55 @@ func TestPendingCmds(t *testing.T) {
 	require.Contains(t, logs, "too many pending commands")
 }
 
-func TestStartError(t *testing.T) {
-	replay := NewReplay(zap.NewNop(), id.NewIDManager())
+func TestLoadEncryptionKey(t *testing.T) {
 	dir := t.TempDir()
 	meta := store.NewMeta(10*time.Second, 20, 0, store.EncryptAes)
 	storage, err := store.NewStorage(dir)
 	require.NoError(t, err)
 	defer storage.Close()
 	require.NoError(t, meta.Write(storage))
+	keyFile := filepath.Join(dir, "encryption")
+	key := make([]byte, 32)
+	require.NoError(t, os.WriteFile(keyFile, key, 0600))
 	now := time.Now()
 
+	tests := []struct {
+		keyFile string
+		err     string
+	}{
+		{
+			err: "encryption",
+		},
+		{
+			keyFile: "/nonexist",
+			err:     "encryption",
+		},
+		{
+			keyFile: keyFile,
+		},
+	}
+
+	loader := newMockNormalLoader()
+	defer loader.Close()
 	cfg := ReplayConfig{
 		Input:     dir,
 		Username:  "u1",
 		StartTime: now,
+		reader:    loader,
+	}
+	for _, test := range tests {
+		cfg.KeyFile = test.keyFile
+		replay := NewReplay(zap.NewNop(), id.NewIDManager())
+		cfg.report = newMockReport(replay.exceptionCh)
+		err = replay.Start(cfg, nil, nil, &backend.BCConfig{})
+		if len(test.err) > 0 {
+			require.ErrorContains(t, err, test.err)
+		} else {
+			require.NoError(t, err)
+			replay.Lock()
+			require.Equal(t, key, replay.cfg.encryptionKey)
+			replay.Unlock()
+			replay.Close()
+		}
 	}
-	err = replay.Start(cfg, nil, nil, &backend.BCConfig{})
-	require.ErrorContains(t, err, "encryption")
 }

pkg/sqlreplay/store/encrypt.go

@@ -121,7 +121,7 @@ func LoadEncryptionKey(encryptionMethod, keyFile string) ([]byte, error) {
 
 func readAesKey(filename string) ([]byte, error) {
 	if len(filename) == 0 {
-		return nil, errors.New("security.encryption-key-file is not set")
+		return nil, errors.New("security.encryption-key-path is not set")
 	}
 	key, err := os.ReadFile(filename)
 	if err != nil {