Skip to content

Commit 7630b9f

Browse files
committed
tweak: search states
1 parent 4c46797 commit 7630b9f

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

src/templates/DocSearchTemplate.tsx

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import {
2929
} from "shared/resources";
3030
import { Locale } from "shared/interface";
3131
import { FeedbackSurveyCampaign } from "components/Campaign/FeedbackSurvey";
32+
import { useEffect } from "react";
3233

3334
// TiDB: get searchable versions from fetchTidbSearchIndcies
3435
// TiDB Cloud: only has one version
@@ -131,10 +132,10 @@ export default function DocSearchTemplate({
131132
const [results, setResults] = React.useState<any[]>([]);
132133

133134
const { language, navigate } = useI18next();
134-
const location = useLocation();
135+
const { search } = useLocation();
135136

136-
React.useEffect(() => {
137-
const searchParams = new URLSearchParams(location.search);
137+
useEffect(() => {
138+
const searchParams = new URLSearchParams(search);
138139
const type = searchParams.get("type") || "";
139140
const version = searchParams.get("version") || "";
140141
const query = searchParams.get("q") || "";
@@ -143,7 +144,7 @@ export default function DocSearchTemplate({
143144
setDocQuery(query);
144145

145146
execSearch(query, type, version);
146-
}, []);
147+
}, [search]);
147148

148149
const realVersionMemo = React.useMemo(() => {
149150
return getSearchIndexVersion(docType, docVersion, language);
@@ -176,28 +177,23 @@ export default function DocSearchTemplate({
176177
};
177178

178179
const handleSelectDocType = (type: string) => {
179-
setDocType(type);
180-
setDocVersion("");
181180
navigate(`/search/?type=${type}&q=${docQuery}`, {
182181
state: {
183182
type,
184183
version: "",
185184
query: docQuery,
186185
},
187186
});
188-
execSearch(docQuery, type, "");
189187
};
190188

191189
const handleSelectDocVersion = (version: string) => {
192-
setDocVersion(version);
193190
navigate(`/search/?type=${docType}&version=${version}&q=${docQuery}`, {
194191
state: {
195192
type: docType,
196193
version,
197194
query: docQuery,
198195
},
199196
});
200-
execSearch(docQuery, docType, version);
201197
};
202198

203199
const bannerVisible = feature?.banner && language !== Locale.ja;
@@ -226,10 +222,6 @@ export default function DocSearchTemplate({
226222
type: docType,
227223
version: realVersionMemo || "stable",
228224
}}
229-
onSubmit={(query) => {
230-
execSearch(query, docType, docVersion);
231-
setDocQuery(query);
232-
}}
233225
/>
234226
<Box
235227
sx={{

0 commit comments

Comments
 (0)