Skip to content

Commit 0763a35

Browse files
hwanseocCopilot
andauthored
Fix bun run dev:desktop from not terminating properly on SIGINT/SIGTERM/SIGHUP (#305)
* fix: handle turbo shutdown in dev runner * refactor: rely on effect child process shutdown * refactor: inline turbo shutdown timeout * add back sigint sigterm sighup handling * refactor: tighten turbo signal forwarding * refactor: inline dev runner errors * fix: use detached false instead of manual signal forwarding Effect defaults to detached: true on non-Windows, putting turbo in a new process group where terminal signals (Ctrl+C) never reach it. Setting detached: false keeps turbo in the same group, eliminating the need for ~130 lines of manual signal forwarding. * Update scripts/dev-runner.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent e1c33dc commit 0763a35

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

scripts/dev-runner.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -455,6 +455,11 @@ export function runDevRunnerWithInput(input: DevRunnerCliInput) {
455455
stderr: "inherit",
456456
env,
457457
extendEnv: false,
458+
// Keep turbo in the same process group so terminal signals (Ctrl+C)
459+
// reach it directly. Effect defaults to detached: true on non-Windows,
460+
// which would put turbo in a new group and require manual forwarding.
461+
detached: false,
462+
forceKillAfter: "1500 millis",
458463
},
459464
);
460465

0 commit comments

Comments
 (0)