[#noissue] Cleanup

Author: emeroad

web/src/main/java/com/navercorp/pinpoint/web/applicationmap/map/VirtualLinkHandler.java

@@ -59,7 +59,7 @@ public LinkDataDuplexMap processVirtualLinks(LinkDataDuplexMap linkDataDuplexMap
             return linkDataDuplexMap;
         }
         logger.debug("Virtual link size : {}", virtualLinkDataSet.size());
-        List<Application> unpopulatedEmulatedNodes = getUnpopulatedEmulatedNodes(linkDataDuplexMap.getTargetLinkDataMap(), virtualLinkDataSet);
+        Collection<Application> unpopulatedEmulatedNodes = getUnpopulatedEmulatedNodes(linkDataDuplexMap.getTargetLinkDataMap(), virtualLinkDataSet);
         if (unpopulatedEmulatedNodes.isEmpty()) {
             logger.debug("unpopulated emulated node not found");
         } else {
@@ -75,15 +75,15 @@ public LinkDataDuplexMap processVirtualLinks(LinkDataDuplexMap linkDataDuplexMap
         return linkDataDuplexMap;
     }
 
-    private List<Application> getUnpopulatedEmulatedNodes(LinkDataMap targetLinkDataMap, Set<LinkData> virtualLinkDataSet) {
+    private Collection<Application> getUnpopulatedEmulatedNodes(LinkDataMap targetLinkDataMap, Set<LinkData> virtualLinkDataSet) {
         Set<Application> unpopulatedEmulatedNodes = new HashSet<>();
         for (LinkData virtualLinkData : virtualLinkDataSet) {
             Application toApplication = virtualLinkData.getToApplication();
             if (targetLinkDataMap.getLinkData(new LinkKey(virtualLinkData.getFromApplication(), toApplication)) == null) {
                 unpopulatedEmulatedNodes.add(toApplication);
             }
         }
-        return new ArrayList<>(unpopulatedEmulatedNodes);
+        return unpopulatedEmulatedNodes;
     }
 
     private Collection<LinkData> getEmulatedNodeInLinkData(LinkVisitChecker linkVisitChecker, Application emulatedNode, TimeWindow timeWindow) {
@@ -95,12 +95,16 @@ private Collection<LinkData> getEmulatedNodeInLinkData(LinkVisitChecker linkVisi
             Application fromApplication = inLinkData.getFromApplication();
             // filter callee link data from non-WAS nodes
             if (!fromApplication.getServiceType().isWas()) {
-                logger.trace("filtered {} as {} is not a WAS node", inLinkData, fromApplication);
+                if (logger.isTraceEnabled()) {
+                    logger.trace("filtered {} as {} is not a WAS node", inLinkData, fromApplication);
+                }
                 continue;
             }
             // filter callee link data from nodes that haven't been visited as we don't need them
             if (!linkVisitChecker.isVisitedOut(fromApplication)) {
-                logger.trace("filtered {} as {} is not in scope of the current server map", inLinkData, fromApplication);
+                if (logger.isTraceEnabled()) {
+                    logger.trace("filtered {} as {} is not in scope of the current server map", inLinkData, fromApplication);
+                }
                 continue;
             }
             logger.debug("emulated node [{}] inLink LinkData:{}", emulatedNode, inLinkData);

web/src/main/java/com/navercorp/pinpoint/web/calltree/span/CallTreeIterator.java

@@ -245,7 +245,7 @@ private CallTreeNode getNext() {
     }
 
     public List<Align> values() {
-        List<Align> values = new ArrayList<>();
+        List<Align> values = new ArrayList<>(nodes.size());
         for (CallTreeNode node : nodes) {
             values.add(node.getAlign());
         }

web/src/main/java/com/navercorp/pinpoint/web/calltree/span/MetaSpanCallTreeFactory.java

@@ -49,14 +49,14 @@ public CallTree unknown(final long startTimeMillis) {
         rootSpan.setStartTime(startTimeMillis);
         rootSpan.setServiceType(ServiceType.UNKNOWN.getCode());
 
-        List<AnnotationBo> annotations = new ArrayList<>();
         ApiMetaDataBo apiMetaData = new ApiMetaDataBo(UNKNOWN_AGENT_ID, AGENT_START_TIME, 0, LineNumber.NO_LINE_NUMBER,
                 MethodTypeEnum.WEB_REQUEST, "Unknown");
-
         final AnnotationBo apiMetaDataAnnotation = AnnotationBo.of(AnnotationKey.API_METADATA.getCode(), apiMetaData);
-        annotations.add(apiMetaDataAnnotation);
 
         final AnnotationBo argumentAnnotation = AnnotationBo.of(AnnotationKeyUtils.getArgs(0).getCode(), "No Agent Data");
+
+        List<AnnotationBo> annotations = new ArrayList<>();
+        annotations.add(apiMetaDataAnnotation);
         annotations.add(argumentAnnotation);
         rootSpan.setAnnotationBoList(annotations);
 
@@ -74,18 +74,16 @@ public SpanCallTree corrupted(final String title, final long parentSpanId, final
         rootSpan.setApplicationName("CORRUPTED");
         rootSpan.setServiceType(ServiceType.UNKNOWN.getCode());
 
-        List<AnnotationBo> annotations = new ArrayList<>();
-
         ApiMetaDataBo apiMetaData = new ApiMetaDataBo(CORRUPTED_AGENT_ID, AGENT_START_TIME, 0, LineNumber.NO_LINE_NUMBER,
                 MethodTypeEnum.CORRUPTED, "...");
-
         final AnnotationBo apiMetaDataAnnotation = AnnotationBo.of(AnnotationKey.API_METADATA.getCode(), apiMetaData);
-        annotations.add(apiMetaDataAnnotation);
-
 
         int key = AnnotationKeyUtils.getArgs(0).getCode();
         String errorMessage = getErrorMessage(title, startTimeMillis);
         final AnnotationBo argumentAnnotation = AnnotationBo.of(key, errorMessage);
+
+        List<AnnotationBo> annotations = new ArrayList<>();
+        annotations.add(apiMetaDataAnnotation);
         annotations.add(argumentAnnotation);
         rootSpan.setAnnotationBoList(annotations);
         return new MetaSpanCallTree(new SpanAlign(rootSpan, true));

web/src/main/java/com/navercorp/pinpoint/web/calltree/span/Node.java

@@ -138,7 +138,7 @@ private List<Align> buildAlignList(List<SpanEventBo> spanEventBoList) {
             return Collections.emptyList();
         }
 
-        List<Align> alignList = new ArrayList<>();
+        List<Align> alignList = new ArrayList<>(spanEventBoList.size());
         for (SpanEventBo spanEventBo : spanEventBoList) {
             if (logger.isDebugEnabled()) {
                 logger.debug("Populate spanEvent{seq={}, depth={}, event={}}", spanEventBo.getSequence(), spanEventBo.getDepth(), spanEventBo);

web/src/main/java/com/navercorp/pinpoint/web/service/ProxyRequestTypeRegistryServiceImpl.java

@@ -75,7 +75,7 @@ public ProxyRequestTypeRegistryServiceImpl() {
     public void init() {
         final ClassLoader classLoader = ClassUtils.getDefaultClassLoader();
         final ServiceLoader<ProxyRequestMetadataProvider> serviceLoader = ServiceLoader.load(ProxyRequestMetadataProvider.class, classLoader);
-        final List<ProxyRequestType> proxyRequestTypeList = new ArrayList<ProxyRequestType>();
+        final List<ProxyRequestType> proxyRequestTypeList = new ArrayList<>();
         for (ProxyRequestMetadataProvider provider : serviceLoader) {
             final ProxyRequestMetadataSetupContext context = new ProxyRequestMetadataSetupContext() {
                 @Override