Skip to content

Commit 4066932

Browse files
committed
fix: camera event type
1 parent 1d8de9a commit 4066932

File tree

8 files changed

+33
-24
lines changed

8 files changed

+33
-24
lines changed

android/src/main/java/com/rngooglemapsplus/GoogleMapsViewImpl.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ class GoogleMapsViewImpl(
368368

369369
var onMapError: ((RNMapErrorCode) -> Unit)? = null
370370
var onMapReady: ((Boolean) -> Unit)? = null
371-
var onMapLoaded: ((RNRegion, RNCamera) -> Unit)? = null
371+
var onMapLoaded: ((RNRegion, RNCameraChange) -> Unit)? = null
372372
var onLocationUpdate: ((RNLocation) -> Unit)? = null
373373
var onLocationError: ((RNLocationErrorCode) -> Unit)? = null
374374
var onMapPress: ((RNLatLng) -> Unit)? = null
@@ -388,9 +388,9 @@ class GoogleMapsViewImpl(
388388
var onInfoWindowLongPress: ((String) -> Unit)? = null
389389
var onMyLocationPress: ((RNLocation) -> Unit)? = null
390390
var onMyLocationButtonPress: ((Boolean) -> Unit)? = null
391-
var onCameraChangeStart: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
392-
var onCameraChange: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
393-
var onCameraChangeComplete: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
391+
var onCameraChangeStart: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
392+
var onCameraChange: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
393+
var onCameraChangeComplete: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
394394

395395
fun showMarkerInfoWindow(id: String) =
396396
onUi {

android/src/main/java/com/rngooglemapsplus/RNGoogleMapsPlusView.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ class RNGoogleMapsPlusView(
305305
view.onMapReady = cb
306306
}
307307

308-
override var onMapLoaded: ((RNRegion, RNCamera) -> Unit)? = null
308+
override var onMapLoaded: ((RNRegion, RNCameraChange) -> Unit)? = null
309309
set(cb) {
310310
view.onMapLoaded = cb
311311
}
@@ -405,17 +405,17 @@ class RNGoogleMapsPlusView(
405405
view.onMyLocationButtonPress = cb
406406
}
407407

408-
override var onCameraChangeStart: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
408+
override var onCameraChangeStart: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
409409
set(cb) {
410410
view.onCameraChangeStart = cb
411411
}
412412

413-
override var onCameraChange: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
413+
override var onCameraChange: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
414414
set(cb) {
415415
view.onCameraChange = cb
416416
}
417417

418-
override var onCameraChangeComplete: ((RNRegion, RNCamera, Boolean) -> Unit)? = null
418+
override var onCameraChangeComplete: ((RNRegion, RNCameraChange, Boolean) -> Unit)? = null
419419
set(cb) {
420420
view.onCameraChangeComplete = cb
421421
}

android/src/main/java/com/rngooglemapsplus/extensions/CameraPositionExtension.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ package com.rngooglemapsplus.extensions
22

33
import com.google.android.gms.maps.model.CameraPosition
44
import com.rngooglemapsplus.RNCamera
5+
import com.rngooglemapsplus.RNCameraChange
56

6-
fun CameraPosition.toRnCamera(): RNCamera =
7-
RNCamera(
7+
fun CameraPosition.toRnCamera(): RNCameraChange =
8+
RNCameraChange(
89
center = target.toRnLatLng(),
910
zoom = zoom.toDouble(),
1011
bearing = bearing.toDouble(),

ios/GoogleMapViewImpl.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ GMSIndoorDisplayDelegate {
261261

262262
var onMapError: ((RNMapErrorCode) -> Void)?
263263
var onMapReady: ((Bool) -> Void)?
264-
var onMapLoaded: ((RNRegion, RNCamera) -> Void)?
264+
var onMapLoaded: ((RNRegion, RNCameraChange) -> Void)?
265265
var onLocationUpdate: ((RNLocation) -> Void)?
266266
var onLocationError: ((_ error: RNLocationErrorCode) -> Void)?
267267
var onMapPress: ((RNLatLng) -> Void)?
@@ -281,9 +281,9 @@ GMSIndoorDisplayDelegate {
281281
var onInfoWindowLongPress: ((String) -> Void)?
282282
var onMyLocationPress: ((RNLocation) -> Void)?
283283
var onMyLocationButtonPress: ((Bool) -> Void)?
284-
var onCameraChangeStart: ((RNRegion, RNCamera, Bool) -> Void)?
285-
var onCameraChange: ((RNRegion, RNCamera, Bool) -> Void)?
286-
var onCameraChangeComplete: ((RNRegion, RNCamera, Bool) -> Void)?
284+
var onCameraChangeStart: ((RNRegion, RNCameraChange, Bool) -> Void)?
285+
var onCameraChange: ((RNRegion, RNCameraChange, Bool) -> Void)?
286+
var onCameraChangeComplete: ((RNRegion, RNCameraChange, Bool) -> Void)?
287287

288288
@MainActor
289289
func showMarkerInfoWindow(id: String) {

ios/RNGoogleMapsPlusView.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ final class RNGoogleMapsPlusView: HybridRNGoogleMapsPlusViewSpec {
331331
didSet { impl.onMapReady = onMapReady }
332332
}
333333
@MainActor
334-
var onMapLoaded: ((RNRegion, RNCamera) -> Void)? {
334+
var onMapLoaded: ((RNRegion, RNCameraChange) -> Void)? {
335335
didSet { impl.onMapLoaded = onMapLoaded }
336336
}
337337
@MainActor
@@ -411,15 +411,15 @@ final class RNGoogleMapsPlusView: HybridRNGoogleMapsPlusViewSpec {
411411
didSet { impl.onMyLocationButtonPress = onMyLocationButtonPress }
412412
}
413413
@MainActor
414-
var onCameraChangeStart: ((RNRegion, RNCamera, Bool) -> Void)? {
414+
var onCameraChangeStart: ((RNRegion, RNCameraChange, Bool) -> Void)? {
415415
didSet { impl.onCameraChangeStart = onCameraChangeStart }
416416
}
417417
@MainActor
418-
var onCameraChange: ((RNRegion, RNCamera, Bool) -> Void)? {
418+
var onCameraChange: ((RNRegion, RNCameraChange, Bool) -> Void)? {
419419
didSet { impl.onCameraChange = onCameraChange }
420420
}
421421
@MainActor
422-
var onCameraChangeComplete: ((RNRegion, RNCamera, Bool) -> Void)? {
422+
var onCameraChangeComplete: ((RNRegion, RNCameraChange, Bool) -> Void)? {
423423
didSet { impl.onCameraChangeComplete = onCameraChangeComplete }
424424
}
425425

ios/extensions/GMSCameraPosition+Extension.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import GoogleMaps
22

33
extension GMSCameraPosition {
4-
func toRNCamera() -> RNCamera {
5-
return RNCamera(
4+
func toRNCamera() -> RNCameraChange {
5+
return RNCameraChange(
66
center: target.toRNLatLng(),
77
zoom: Double(zoom),
88
bearing: bearing,

src/RNGoogleMapsPlusView.nitro.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import type {
55
} from 'react-native-nitro-modules';
66
import type {
77
RNCamera,
8+
RNCameraChange,
89
RNLatLng,
910
RNMapPadding,
1011
RNPolygon,
@@ -53,7 +54,7 @@ export interface RNGoogleMapsPlusViewProps extends HybridViewProps {
5354
locationConfig?: RNLocationConfig;
5455
onMapError?: (error: RNMapErrorCode) => void;
5556
onMapReady?: (ready: boolean) => void;
56-
onMapLoaded?: (region: RNRegion, camera: RNCamera) => void;
57+
onMapLoaded?: (region: RNRegion, camera: RNCameraChange) => void;
5758
onLocationUpdate?: (location: RNLocation) => void;
5859
onLocationError?: (error: RNLocationErrorCode) => void;
5960
onMapPress?: (coordinate: RNLatLng) => void;
@@ -75,17 +76,17 @@ export interface RNGoogleMapsPlusViewProps extends HybridViewProps {
7576
onMyLocationButtonPress?: (pressed: boolean) => void;
7677
onCameraChangeStart?: (
7778
region: RNRegion,
78-
camera: RNCamera,
79+
camera: RNCameraChange,
7980
isGesture: boolean
8081
) => void;
8182
onCameraChange?: (
8283
region: RNRegion,
83-
camera: RNCamera,
84+
camera: RNCameraChange,
8485
isGesture: boolean
8586
) => void;
8687
onCameraChangeComplete?: (
8788
region: RNRegion,
88-
camera: RNCamera,
89+
camera: RNCameraChange,
8990
isGesture: boolean
9091
) => void;
9192
}

src/types.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,13 @@ export interface RNMapStyleElement {
130130
stylers: RNMapStyler[];
131131
}
132132

133+
export type RNCameraChange = {
134+
center: RNLatLng;
135+
zoom: number;
136+
bearing: number;
137+
tilt: number;
138+
};
139+
133140
export type RNCamera = {
134141
center?: RNLatLng;
135142
zoom?: number;

0 commit comments

Comments
 (0)