The post-deploy webhook is currently only called on successful deploys

[smeder]

Right now the post-deploy webhook is only called on successful deploys and the deploy state is not updated before calling the webhook. This causes the deploy state to always be RUNNING when the webhook is being called, so the deploy state variable substitution is currently meaningless.

[lilida]

@sbaogang While looking at the code, I think there are some inconsistencies here on how we handle the deploy event and webhooks.

1. We notify webhook when succeeding the deploy

`

if (succeeded * 10000 >= sucThreshold * total) {
LOG.debug("Propose deploy {} as SUCCEEDING since {} agents are succeeded.", deployId, succeeded);
if (deployBean.getSuc_date() == null) {
newDeployBean.setSuc_date(System.currentTimeMillis());

            // Submit post-webhooks, if exists
            EnvWebHookBean webhooks = dataHandler.getDataById(envBean.getWebhooks_config_id(), WebhookDataFactory.class);

`

2. In the outside function internalTransition, we trigger
   `

   if (shouldSendFinishMessage(state, newPartialDeployBean.getState(), deployBean.getSuc_date())) {
       jobPool.submit(new FinishNotifyJob(envBean, deployBean, newPartialDeployBean, deployBean.getBuild_id()));
   }
   

`

Should these two be in the same place? Should we send the notification for both succeeding and failing state?