fix(logger): Turn on smart features in more cases

Jason2866 · radimkarnis · commit 5d5eafb70340 · 2025-07-01T09:50:05.000+02:00
Closes espressif#1096 use term_supports_color as decider
diff --git a/esptool/logger.py b/esptool/logger.py
@@ -115,7 +115,7 @@ def _set_smart_features(cls, override: bool | None = None):
 
             # Determine if colors should be enabled
             cls.instance._smart_features = (
-                is_tty and term_supports_color and not no_color
+                is_tty or term_supports_color and not no_color
             )
             # Handle Windows specifically
             if sys.platform == "win32" and cls.instance._smart_features:

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ def _set_smart_features(cls, override: bool \| None = None):`
`115`	`115`
`116`	`116`	`# Determine if colors should be enabled`
`117`	`117`	`cls.instance._smart_features = (`
`118`		`- is_tty and term_supports_color and not no_color`
	`118`	`+ is_tty or term_supports_color and not no_color`
`119`	`119`	`)`
`120`	`120`	`# Handle Windows specifically`
`121`	`121`	`if sys.platform == "win32" and cls.instance._smart_features:`