fix: close port when connect fails

Dzarda7 · radimkarnis · commit d99c97215641 · 2025-01-08T23:18:50.000+08:00
This fixes a bug where the serial port is not closed when the connect fails. This can cause the port to be left open and unusable. This occurs when esptool is used as a module and detect_chip is called. Closes espressif#1044
diff --git a/esptool/loader.py b/esptool/loader.py
@@ -737,7 +737,7 @@ def connect(
                     " if ESP32-C2 doesn't connect"
                     " (at least 115200 Bd is recommended)."
                 )
-
+            self._port.close()
             raise FatalError(
                 "Failed to connect to {}: {}"
                 f"{additional_msg}"

Original file line number	Diff line number	Diff line change
`@@ -737,7 +737,7 @@ def connect(`
`737`	`737`	`" if ESP32-C2 doesn't connect"`
`738`	`738`	`" (at least 115200 Bd is recommended)."`
`739`	`739`	`)`
`740`		`-`
	`740`	`+ self._port.close()`
`741`	`741`	`raise FatalError(`
`742`	`742`	`"Failed to connect to {}: {}"`
`743`	`743`	`f"{additional_msg}"`