Fix Offline mode (#3)

* fix starting install when no inet connection

Author: Jason2866

assets/welcome/pioarduino-ini-example.md

@@ -1,7 +1,7 @@
 ```ini
 ; Common configuration
 [env]
-platform = https://github.com/pioarduino/platform-espressif32/releases/download/51.03.04/platform-espressif32.zip
+platform = https://github.com/pioarduino/platform-espressif32/releases/download/stable/platform-espressif32.zip
 framework = arduino
 board = esp32doit-devkit-v1
 monitor_speed = 921600

src/installer/manager.js

@@ -6,7 +6,8 @@
  * the root directory of this source tree.
  */
 
-import * as pioNodeHelpers from 'pioarduino-node-helpers';
+// DON'T import pioNodeHelpers here - it causes immediate initialization!
+// import * as pioNodeHelpers from 'pioarduino-node-helpers';
 
 import PIOHome from '../home';
 import { PIO_CORE_VERSION_SPEC } from '../constants';
@@ -21,28 +22,10 @@ export default class InstallationManager {
 
   constructor(disableAutoUpdates = false) {
     const config = vscode.workspace.getConfiguration('platformio-ide');
-    this.stages = [
-      new pioNodeHelpers.installer.pioarduinoCoreStage(
-        {
-          getValue: (key) => extension.context.globalState.get(key),
-          setValue: (key, value) => extension.context.globalState.update(key, value),
-        },
-        this.onDidStatusChange.bind(this),
-        {
-          pioCoreVersionSpec: PIO_CORE_VERSION_SPEC,
-          useBuiltinPython: config.get('useBuiltinPython'),
-          useBuiltinPIOCore: config.get('useBuiltinPIOCore'),
-          useDevelopmentPIOCore: config.get('useDevelopmentPIOCore'),
-          pythonPrompt: new PythonPrompt(),
-          disableAutoUpdates: disableAutoUpdates,
-          predownloadedPackageDir: path.join(
-            extension.context.extensionPath,
-            'assets',
-            'predownloaded',
-          ),
-        },
-      ),
-    ];
+    this.config = config;
+    this.disableAutoUpdates = disableAutoUpdates;
+    // Create stages lazily - the node-helpers now handle offline checks internally
+    this.stages = null;
   }
 
   onDidStatusChange() {
@@ -68,7 +51,39 @@ export default class InstallationManager {
     return new Date().getTime() - parseInt(lockTime) <= this.LOCK_TIMEOUT;
   }
 
+  createStages() {
+    if (this.stages === null) {
+      // Lazy load pioNodeHelpers only when needed
+      const pioNodeHelpers = require('pioarduino-node-helpers');
+      this.stages = [
+        new pioNodeHelpers.installer.pioarduinoCoreStage(
+          {
+            getValue: (key) => extension.context.globalState.get(key),
+            setValue: (key, value) => extension.context.globalState.update(key, value),
+          },
+          this.onDidStatusChange.bind(this),
+          {
+            pioCoreVersionSpec: PIO_CORE_VERSION_SPEC,
+            useBuiltinPython: this.config.get('useBuiltinPython'),
+            useBuiltinPIOCore: this.config.get('useBuiltinPIOCore'),
+            useDevelopmentPIOCore: this.config.get('useDevelopmentPIOCore'),
+            pythonPrompt: new PythonPrompt(),
+            disableAutoUpdates: this.disableAutoUpdates,
+            predownloadedPackageDir: path.join(
+              extension.context.extensionPath,
+              'assets',
+              'predownloaded',
+            ),
+          },
+        ),
+      ];
+    }
+  }
+
   async check() {
+    // Create stages if needed
+    this.createStages();
+
     let result = true;
     for (const stage of this.stages) {
       try {
@@ -77,13 +92,16 @@ export default class InstallationManager {
         }
       } catch (err) {
         result = false;
-        console.warn(err);
+        console.warn('Installation stage check failed:', err.message || err);
       }
     }
     return result;
   }
 
   async install(progress) {
+    // Ensure stages are created
+    this.createStages();
+
     const stageIncrementTotal = 100 / this.stages.length;
     // shutdown all PIO Home servers which block python.exe on Windows
     await PIOHome.shutdownAllServers();
@@ -99,6 +117,15 @@ export default class InstallationManager {
   }
 
   destroy() {
-    return this.stages.map((stage) => stage.destroy());
+    if (this.stages) {
+      for (const stage of this.stages) {
+        try {
+          if (stage && typeof stage.destroy === 'function') {
+            stage.destroy();
+          }
+        } catch (err) {}
+      }
+    }
+    this.stages = null;
   }
 }

src/main.js

@@ -7,7 +7,7 @@
  */
 
 import * as misc from './misc';
-import * as pioNodeHelpers from 'pioarduino-node-helpers';
+// import * as pioNodeHelpers from 'pioarduino-node-helpers';  // Lazy load this!
 import * as piodebug from 'platformio-vscode-debug';
 import * as utils from './utils';
 
@@ -148,6 +148,7 @@ class PlatformIOVSCodeExtension {
     if (this.getConfiguration('customPyPiIndexUrl')) {
       extraVars['PIP_INDEX_URL'] = this.getConfiguration('customPyPiIndexUrl');
     }
+    const pioNodeHelpers = require('pioarduino-node-helpers');
     pioNodeHelpers.proc.patchOSEnviron({
       caller: 'vscode',
       extraPath: this.getConfiguration('customPATH'),
@@ -175,8 +176,12 @@ class PlatformIOVSCodeExtension {
         });
         try {
           return !(await im.check());
-        } catch (err) {}
-        return true;
+        } catch (err) {
+          // In case of network errors or other issues, assume an existing installation is OK
+          // and no installation is required
+          console.warn('Installation check failed:', err);
+          return false; // No installation required
+        }
       },
     );
 
@@ -236,6 +241,7 @@ class PlatformIOVSCodeExtension {
   }
 
   async startPIOHome() {
+    const pioNodeHelpers = require('pioarduino-node-helpers');
     if (
       this.getConfiguration('disablePIOHomeStartup') ||
       !pioNodeHelpers.home.showAtStartup('vscode')
@@ -282,6 +288,7 @@ class PlatformIOVSCodeExtension {
       ) {
         return;
       }
+      const pioNodeHelpers = require('pioarduino-node-helpers');
       const envDir = pioNodeHelpers.core.getEnvDir();
       if (!envDir || !fs.isDirectorySync(envDir)) {
         return;

src/terminal.js

@@ -24,7 +24,7 @@ export default class PIOTerminal {
       env: envClone,
     });
     // Set Codepage to UTF-8, if Windows is used
-    if (process.platform === "win32") {
+    if (process.platform === 'win32') {
       terminal.sendText('chcp 65001');
     }
     return terminal;
@@ -34,7 +34,7 @@ export default class PIOTerminal {
     if (!this._instance || this._instance.exitStatus !== undefined) {
       this._instance = this.new();
       // Set Codepage to UTF-8, if Windows is used
-      if (process.platform === "win32") {
+      if (process.platform === 'win32') {
         this._instance.sendText('chcp 65001');
       }
     }

src/utils.js

@@ -6,7 +6,7 @@
  * the root directory of this source tree.
  */
 
-import * as pioNodeHelpers from 'pioarduino-node-helpers';
+// import * as pioNodeHelpers from 'pioarduino-node-helpers';  // Lazy load!
 
 import os from 'os';
 import vscode from 'vscode';
@@ -36,6 +36,7 @@ export async function notifyError(title, err) {
   ${description}
   \`\`\`
   `;
+  const pioNodeHelpers = require('pioarduino-node-helpers');
   const reportUrl = pioNodeHelpers.misc.getErrorReportUrl(title, ghbody);
 
   let action = 'Report a problem';
@@ -62,6 +63,7 @@ export function getIDEVersion() {
 }
 
 export async function listCoreSerialPorts() {
+  const pioNodeHelpers = require('pioarduino-node-helpers');
   const script = `
 import json
 from platformio.public import list_serial_ports