Skip to content

Commit 2c1b430

Browse files
committed
Handle spaces in paths when compiling for ULP // Resolve #208
1 parent d63f559 commit 2c1b430

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

builder/frameworks/ulp.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def bin_converter(target, source, env):
4444
"elf32-xtensa-le", "--binary-architecture",
4545
"xtensa", "--rename-section",
4646
".data=.rodata.embedded",
47-
source[0].name, target[0].get_path()
47+
source[0].name, '"%s"' % target[0].get_path()
4848
])
4949

5050
ulp_env.Execute(command)
@@ -64,7 +64,7 @@ def bin_converter(target, source, env):
6464
"esp32ulp-elf-ld",
6565
"-o", "$TARGET",
6666
"-A", "elf32-esp32ulp",
67-
"-L", ULP_BUILD_DIR,
67+
"-L", '"%s"' % ULP_BUILD_DIR,
6868
"-T", "ulp_main.common.ld",
6969
"$SOURCES"
7070
]), "Linking $TARGET"),
@@ -89,7 +89,7 @@ def bin_converter(target, source, env):
8989
"-DWITH_POSIX", "-DHAVE_CONFIG_H",
9090
"-MT", "${TARGET}.o",
9191
"-DMBEDTLS_CONFIG_FILE=\"mbedtls/esp_config.h\"",
92-
"-I %s" % join(
92+
'-I "%s"' % join(
9393
FRAMEWORK_DIR, "components", "soc", "esp32", "include"),
9494
"-E", "-P", "-xc",
9595
"-o", "$TARGET", "-D__ASSEMBLER__", "$SOURCE"
@@ -143,7 +143,7 @@ def generate_export_files(symbol_file):
143143
[join(ULP_BUILD_DIR, "ulp_main.ld"),
144144
join(ULP_BUILD_DIR, "ulp_main.h")], symbol_file,
145145
ulp_env.VerboseAction(
146-
'"$PYTHONEXE" "%s" -s $SOURCE -o %s' % (gen_script, build_suffix),
146+
'"$PYTHONEXE" "%s" -s $SOURCE -o "%s"' % (gen_script, build_suffix),
147147
"Exporting ULP linker and header files"))
148148

149149

examples/espidf-ulp-adc/platformio.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
; Please visit documentation for the other options and examples
88
; http://docs.platformio.org/page/projectconf.html
99

10-
[env:esp32dev]
10+
[env:esp32 dev]
1111
platform = espressif32
1212
framework = espidf
1313
board = esp32dev

0 commit comments

Comments
 (0)