Skip to content

Commit 5d203d2

Browse files
authored
changes + fix in ULP
1 parent bab33a8 commit 5d203d2

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

builder/frameworks/ulp.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,14 @@
3131
BUILD_DIR, "esp-idf", project_config["name"].replace("__idf_", ""), "ulp_main"
3232
)
3333

34+
is_xtensa = idf_variant in ("esp32", "esp32s2", "esp32s3")
3435

3536
def prepare_ulp_env_vars(env):
3637
ulp_env.PrependENVPath("IDF_PATH", FRAMEWORK_DIR)
3738

3839
toolchain_path = platform.get_package_dir(
3940
"toolchain-xtensa-esp-elf"
40-
if idf_variant in ("esp32","esp32s2","esp32s3")
41+
if is_xtensa
4142
else "toolchain-riscv32-esp"
4243
)
4344

@@ -47,12 +48,13 @@ def prepare_ulp_env_vars(env):
4748
else ""
4849
)
4950

51+
python_dir = os.path.dirname(ulp_env.subst("$PYTHONEXE")) or ""
5052
additional_packages = [
5153
toolchain_path,
5254
toolchain_path_ulp,
5355
platform.get_package_dir("tool-ninja"),
5456
os.path.join(platform.get_package_dir("tool-cmake"), "bin"),
55-
os.path.dirname(where_is_program("python")),
57+
python_dir,
5658
]
5759

5860
for package in additional_packages:
@@ -85,17 +87,17 @@ def _generate_ulp_configuration_action(env, target, source):
8587
riscv_ulp_enabled = sdk_config.get("ULP_COPROC_TYPE_RISCV", False)
8688
lp_core_ulp_enabled = sdk_config.get("ULP_COPROC_TYPE_LP_CORE", False)
8789

88-
if lp_core_ulp_enabled == False:
90+
if not lp_core_ulp_enabled:
8991
ulp_toolchain = "toolchain-%sulp%s.cmake"% (
9092
"" if riscv_ulp_enabled else idf_variant + "-",
9193
"-riscv" if riscv_ulp_enabled else "",
9294
)
9395
else:
9496
ulp_toolchain = "toolchain-lp-core-riscv.cmake"
9597

96-
comp_includes = ";".join(get_component_includes(target_config))
97-
plain_includes = ";".join(app_includes["plain_includes"])
98-
comp_includes = comp_includes + plain_includes
98+
comp_includes_list = get_component_includes(target_config)
99+
plain_includes_list = app_includes["plain_includes"]
100+
comp_includes = ";".join(comp_includes_list + plain_includes_list)
99101

100102
cmd = (
101103
os.path.join(platform.get_package_dir("tool-cmake"), "bin", "cmake"),

0 commit comments

Comments
 (0)