Skip to content

Commit ec2d01f

Browse files
committed
Ensured that dependencies of private libraries are no longer unnecessarily re-installed // Resolve platformio#4987
1 parent 4e05309 commit ec2d01f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

HISTORY.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ test-driven methodologies, and modern toolchains for unrivaled success.
2222
~~~~~~~~~~~~~~~~~~~
2323

2424
* Added support for ``tar.xz`` tarball dependencies (`pull #4974 <https://github.com/platformio/platformio-core/pull/4974>`_)
25+
* Ensured that dependencies of private libraries are no longer unnecessarily re-installed, optimizing dependency management and reducing redundant operations (`issue #4987 <https://github.com/platformio/platformio-core/issues/4987>`_)
2526
* Resolved an issue where the ``compiledb`` target failed to properly escape compiler executable paths containing spaces (`issue #4998 <https://github.com/platformio/platformio-core/issues/4998>`_)
2627
* Resolved an issue with incorrect path resolution when linking static libraries via the `build_flags <https://docs.platformio.org/en/latest/projectconf/sections/env/options/build/build_flags.html>`__ option (`issue #5004 <https://github.com/platformio/platformio-core/issues/5004>`_)
2728

platformio/package/commands/install.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,11 @@ def _install_project_private_library_deps(private_pkg, private_lm, env_lm, optio
297297
if not spec.external and not spec.owner:
298298
continue
299299
pkg = private_lm.get_package(spec)
300-
if not pkg and not env_lm.get_package(spec):
300+
if (
301+
not pkg
302+
and not private_lm.get_package(spec)
303+
and not env_lm.get_package(spec)
304+
):
301305
pkg = env_lm.install(
302306
spec,
303307
skip_dependencies=True,

0 commit comments

Comments
 (0)