[ci skip] Add note that this change may break SetOption() + ninja usage with fix

Author: bdbaddog

CHANGES.txt

@@ -102,6 +102,10 @@ RELEASE  VERSION/DATE TO BE FILLED IN LATER
     - AddOption and the internal add_local_option which AddOption calls now
       recognize a "settable" keyword argument to indicate a project-added
       option can also be modified using SetOption. Fixes #3983.
+      NOTE: If you were using ninja and using SetOption() for ninja options
+      in your SConscripts prior to loading the ninja tool, you will now
+      see an error. The fix is to move the SetOption() to after you've loaded
+      the ninja tool.
     - ListVariable now has a separate validator, with the functionality
       that was previously part of the converter. The main effect is to
       allow a developer to supply a custom validator, which previously

RELEASE.txt

@@ -56,6 +56,10 @@ CHANGED/ENHANCED EXISTING FUNCTIONALITY
 - AddOption and the internal add_local_option which AddOption calls now
   recognize a "settable" keyword argument to indicate a project-added
   option can also be modified using SetOption.
+  NOTE: If you were using ninja and using SetOption() for ninja options
+  in your SConscripts prior to loading the ninja tool, you will now
+  see an error. The fix is to move the SetOption() to after you've loaded
+  the ninja tool.
 - ListVariable now has a separate validator, with the functionality
   that was previously part of the converter. The main effect is to
   allow a developer to supply a custom validator, which previously