Test suite update and bug fixes.

Changes:
* Bug fix for not found toolset version in vcTests.py
* Re-work sdk list tests in vcTests.py when run on machine that may not have sdks installed (no msvc or older msvc).  Potential future problem lurking as the gap between supported sdk versions grows with future releases.
* Update the tolerance for precompiled header "fast enough" in msvc.py. This test, more than others, has a tendency to fail when run in a virtual machine on Windows.
* Explicity run "foo.exe" instead of "foo" in vs-14.3-exec.py.  A recent change in VS2022 appears to create a "foo" folder which causes the test to fail.

Author: jcbrill

SCons/Tool/MSCommon/vcTests.py

@@ -215,7 +215,14 @@ def runTest(self) -> None:
 
 class Data:
 
-    HAVE_MSVC = True if MSCommon.vc.msvc_default_version() else False
+    DEFAULT_VERSION = MSCommon.vc.msvc_default_version()
+
+    if DEFAULT_VERSION:
+        HAVE_MSVC = True
+        DEFAULT_VERSION_DEF = MSCommon.msvc_version_components(DEFAULT_VERSION)
+    else:
+        HAVE_MSVC = False
+        DEFAULT_VERSION_DEF = None
 
     INSTALLED_VCS_COMPONENTS = MSCommon.vc.get_installed_vcs_components()
 
@@ -230,11 +237,11 @@ def _msvc_toolset_notfound_list(cls, toolset_seen, toolset_list):
             if len(comps) != 3:
                 continue
             # full versions only
+            ival = int(comps[-1])
             nloop = 0
             while nloop < 10:
-                ival = int(comps[-1])
                 if ival == 0:
-                    ival = 1000000
+                    ival = 100000
                 ival -= 1
                 version = '{}.{}.{:05d}'.format(comps[0], comps[1], ival)
                 if version not in toolset_seen:
@@ -310,10 +317,18 @@ def test_valid_vcver(self) -> None:
             version_def = MSCommon.msvc_version_components(symbol)
             for msvc_uwp_app in (True, False):
                 sdk_list = MSCommon.vc.msvc_sdk_versions(version=symbol, msvc_uwp_app=msvc_uwp_app)
-                if Data.HAVE_MSVC and version_def.msvc_vernum >= 14.0:
+                if version_def.msvc_vernum < 14.0:
+                    # version < VS2015
+                    # does not accept sdk version argument
+                    self.assertFalse(sdk_list, "SDK list is not empty for msvc version {}".format(repr(symbol)))
+                elif Data.HAVE_MSVC and Data.DEFAULT_VERSION_DEF.msvc_vernum >= 14.0:
+                    # version >= VS2015 and default_version >= VS2015
+                    # no guarantee test is valid: compatible sdks may not be installed as version gap grows
                     self.assertTrue(sdk_list, "SDK list is empty for msvc version {}".format(repr(symbol)))
                 else:
-                    self.assertFalse(sdk_list, "SDK list is not empty for msvc version {}".format(repr(symbol)))
+                    # version >= VS2015 and default_version < VS2015
+                    # skip test: version is not installed; compatible windows sdks may not be installed
+                    pass
 
     def test_valid_vcver_toolsets(self) -> None:
         for symbol in MSCommon.vc._VCVER:

test/MSVC/msvc.py

@@ -116,7 +116,7 @@
 
 # TODO: Reevaluate if having this part of the test makes sense any longer
 # using precompiled headers should be faster
-limit = slow*0.90
+limit = slow
 if fast >= limit:
     print("Using precompiled headers was not fast enough:")
     print("slow.obj:  %.3fs" % slow)

test/MSVS/vs-14.3-exec.py

@@ -104,7 +104,7 @@
          program=[test.get_msvs_executable(msvs_version)],
          arguments=['foo.sln', '/build', 'Release'])
 
-test.run(program=test.workpath('sub dir', 'foo'), stdout="foo.c\n")
+test.run(program=test.workpath('sub dir', 'foo.exe'), stdout="foo.c\n")
 test.validate_msvs_file(test.workpath('sub dir', 'foo.vcxproj.user'))