Skip to content

Commit caa6539

Browse files
committed
Add additional registry keys for 12.0Exp and 11.0Exp detection (VS roots).
1 parent d06ad9e commit caa6539

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

SCons/Tool/MSCommon/vc.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -788,21 +788,25 @@ def _skip_sendtelemetry(env):
788788
# VS2015 and earlier: configure registry queries to probe for installed VC editions
789789
_VCVER_TO_PRODUCT_DIR = {
790790
'14.0': [
791-
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\14.0\Setup\VC\ProductDir')],
791+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\14.0\Setup\VC\ProductDir')
792+
],
792793
'14.0Exp': [
793-
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\WDExpress\14.0\Setup\VS\ProductDir'), # vs root
794-
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VCExpress\14.0\Setup\VC\ProductDir'), # not populated?
795-
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\14.0\Setup\VC\ProductDir')], # kind detection
794+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\WDExpress\14.0\Setup\VS\ProductDir'),
795+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VCExpress\14.0\Setup\VC\ProductDir'),
796+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\14.0\Setup\VC\ProductDir')
797+
],
796798
'12.0': [
797799
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\12.0\Setup\VC\ProductDir'),
798800
],
799801
'12.0Exp': [
802+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\WDExpress\12.0\Setup\VS\ProductDir'),
800803
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VCExpress\12.0\Setup\VC\ProductDir'),
801804
],
802805
'11.0': [
803806
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VisualStudio\11.0\Setup\VC\ProductDir'),
804807
],
805808
'11.0Exp': [
809+
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\WDExpress\11.0\Setup\VS\ProductDir'),
806810
(SCons.Util.HKEY_LOCAL_MACHINE, r'Microsoft\VCExpress\11.0\Setup\VC\ProductDir'),
807811
],
808812
'10.0': [
@@ -1415,8 +1419,8 @@ def find_vc_pdir_registry(msvc_version):
14151419
# Visual C++ for Python registry key is VS installdir (root) not VC productdir
14161420
is_vsroot = True
14171421
is_vcforpython = True
1418-
elif msvc_version == '14.0Exp' and key.lower().endswith('\\14.0\\setup\\vs\\productdir'):
1419-
# 2015Exp VS productdir (root) not VC productdir
1422+
elif msvc_version in ('14.0Exp', '12.0Exp', '11.0Exp') and key.lower().endswith('\\setup\\vs\\productdir'):
1423+
# Visual Studio 2015/2013/2012 Express is VS productdir (root) not VC productdir
14201424
is_vsroot = True
14211425

14221426
if is_vsroot:

0 commit comments

Comments
 (0)