Skip to content

Commit e27b28c

Browse files
committed
Remove incorrect dependencies from setup.cfg
Remove the `install_requires` on `setuptools`. This key is used to specify packages that are needed at runtime. SCons nowhere in its code does import `setuptools` or `pkg_resources`. Remove the `setup_requires` on `build`. `build` is a frontend package and a detail of how the build is invoked, while `setup_requires` are used to specify backend dependencies (i.e. packages that are installed after `build` is invoked). Remove the `setup_requires` on `setuptools`. It is a key specific to setuptools, so for it to be interpreted `setuptools` need to be installed already. The actual backend dependency on `setuptools` is specified in `pyproject.toml`, so the dependency is entirely redundant.
1 parent 0265b1a commit e27b28c

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

CHANGES.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ NOTE: 4.3.0 now requires Python 3.6.0 and above. Python 3.5.x is no longer suppo
99

1010
RELEASE VERSION/DATE TO BE FILLED IN LATER
1111

12-
From John Doe:
13-
14-
- Whatever John Doe did.
12+
From Michał Górny:
13+
- Remove unecessary dependencies on pypi packages from setup.cfg
1514

1615

1716
RELEASE 4.6.0 - Sun, 19 Nov 2023 17:22:20 -0700

RELEASE.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ IMPROVEMENTS
4444
PACKAGING
4545
---------
4646

47-
- List changes in the way SCons is packaged and/or released
47+
- Remove unecessary dependencies on pypi packages from setup.cfg
4848

4949
DOCUMENTATION
5050
-------------

setup.cfg

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@ classifiers =
4545
[options]
4646
zip_safe = False
4747
python_requires = >=3.6
48-
install_requires = setuptools
49-
setup_requires =
50-
setuptools
51-
build
5248
include_package_data = True
5349
packages = find:
5450

0 commit comments

Comments
 (0)