Skip to content

Commit e696718

Browse files
committed
Fixes from review
typo fix; more explanation of AppendUnique in DummyEnvironment test class. Signed-off-by: Mats Wichmann <[email protected]>
1 parent fae4e06 commit e696718

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

SCons/Tool/ToolTests.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ def Detect(self, progs):
3939
return progs[0]
4040
def Append(self, **kw) -> None:
4141
self.dict.update(kw)
42-
AppendUnique = Append # wrong, but good enough for the use
42+
# Adding a tool now calls AppendUnique so we need a mocked one. Since
43+
# the only usage is adding one tool, using Append is good enough.
44+
AppendUnique = Append
4345
def __getitem__(self, key):
4446
return self.dict[key]
4547
def __setitem__(self, key, val) -> None:

doc/man/scons.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7725,8 +7725,8 @@ A tool specification module has two required entry points:
77257725
<para>Modify the &consenv; <parameter>env</parameter>
77267726
to set up necessary &consvars;, Builders, Emitters, etc.,
77277727
so the facilities represented by the tool can be executed.
7728-
Take Care not to overwrite &consvars; which may
7729-
have been explicitly set by the user,
7728+
Take care not to overwrite &consvars; which may
7729+
have been explicitly set by the user;
77307730
retain and/or append instead. For example:
77317731
</para>
77327732
<programlisting language="python">

0 commit comments

Comments
 (0)