Skip to content

Commit ed18bdf

Browse files
committed
Update CHANGES.txt and RELEASE.txt: move text items and fix typographical errors to prepare for merge with latest.
1 parent fd2ec85 commit ed18bdf

File tree

2 files changed

+41
-41
lines changed

2 files changed

+41
-41
lines changed

CHANGES.txt

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,24 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER
4242
registry query that returns a path that does not exist. Multiple invocation
4343
paths were not prepared to handle the MissingConfiguration exception. The
4444
MissingConfiguration exception type was removed.
45+
- The MSCommon module import was changed from a relative import to a top-level
46+
absolute import in the following Microsoft tools: midl, mslib, mslink, mssdk, msvc,
47+
msvs. Moving any of these tools that used relative imports to the scons site tools
48+
folder would fail on import (i.e., the relative import paths become invalid when
49+
moved).
50+
- The detection of the msvc compiler executable (cl.exe) has been modified. The
51+
compiler detection no longer considers the host os environment path. In addition,
52+
existence of the msvc compiler executable is checked in the detection dictionary
53+
and the scons ENV path before the detection dictionary is merged into the scons
54+
ENV. Different warnings are produced when the msvc compiler is not detected in the
55+
detection dictionary based on whether or not an msvc compiler was detected in the
56+
scons ENV path (i.e., already exists in the user's ENV path prior to detection).
4557
- For msvc version specifications without an 'Exp' suffix, an express installation
4658
is used when no other edition is detected for the msvc version.
47-
- VS2015 Express (14.1Exp) may not have been detected. The registry keys written
59+
- VS2015 Express (14.0Exp) may not have been detected. The registry keys written
4860
during installation appear to be different than for earlier express versions.
4961
VS2015 Express should be correctly detected now.
50-
- VS2015 Express (14.1Exp) does not support the sdk version argument. VS2015 Express
62+
- VS2015 Express (14.0Exp) does not support the sdk version argument. VS2015 Express
5163
does not support the store argument for target architectures other than x86.
5264
Script argument validation now takes into account these restrictions.
5365
- VS2015 BuildTools (14.0) does not support the sdk version argument and does not
@@ -60,11 +72,6 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER
6072
batch files will fail. The msvc detection logic now ignores SDK-only VS2010
6173
installations. Similar protection is implemented for the sdk-only installs that
6274
populate the installation folder and registry keys for VS2008 (9.0), if necessary.
63-
- The MSCommon module import was changed from a relative import to a top-level
64-
absolute import in the following Microsoft tools: midl, mslib, mslink, mssdk, msvc,
65-
msvs. Moving any of these tools that used relative imports to the scons site tools
66-
folder would fail on import (i.e., the relative import paths become invalid when
67-
moved).
6875
- For VS2005 (8.0) to VS2015 (14.0), vsvarsall.bat is employed to dispatch to a
6976
dependent batch file when configuring the msvc environment. Previously, only the
7077
existence of the compiler executable was verified. In certain installations, the
@@ -88,13 +95,6 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER
8895
of the results from all vswhere executables). There is a single invocation for
8996
each vswhere executable that processes the output for all installations. Prior
9097
implementations called the vswhere executable for each supported msvc version.
91-
- The detection of the msvc compiler executable (cl.exe) has been modified. The
92-
compiler detection no longer considers the host os environment path. In addition,
93-
existence of the msvc compiler executable is checked in the detection dictionary
94-
and the scons ENV path before the detection dictionary is merged into the scons
95-
ENV. Different warnings are produced when the msvc compiler is not detected in the
96-
detection dictionary based on whether or not an msvc compiler was detected in the
97-
scons ENV path (i.e., already exists in the user's ENV path prior to detection).
9898
- Previously, the installed vcs list was constructed once and cached at runtime. If
9999
a vswhere executable was specified via the construction variable VSWHERE and found
100100
additional msvc installations, the new installations were not reflected in the

RELEASE.txt

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ CHANGED/ENHANCED EXISTING FUNCTIONALITY
5959
batch file exists but an individual msvc toolset may not support the host/target
6060
architecture combination. For example, when using VS2022 on arm64, the arm64 native
6161
tools are only installed for the 14.3x toolsets.
62-
- MSVC: For msvc version specifications without an 'Exp' suffix, an express
63-
installation is used when no other edition is detected for the msvc version.
64-
This was the behavior for VS2008 (9.0) through VS2015 (14.0). This behavior
65-
was extended to VS2017 (14.1) and VS2008 (8.0).
6662
- MSVC: When the msvc compiler executable is not found during setup of the msvc
6763
environment, the warning message issued takes into account whether or not a
6864
possibly erroneous compiler executable was already present in the scons environment
@@ -86,6 +82,10 @@ CHANGED/ENHANCED EXISTING FUNCTIONALITY
8682
although the preferred usage remains to import from SCons.Util only.
8783
Any code that did the direct import will have to change to import from
8884
SCons.Util.sctypes.
85+
- MSVC: For msvc version specifications without an 'Exp' suffix, an express
86+
installation is used when no other edition is detected for the msvc version.
87+
This was the behavior for VS2008 (9.0) through VS2015 (14.0). This behavior
88+
was extended to VS2017 (14.1) and VS2008 (8.0).
8989

9090
FIXES
9191
-----
@@ -109,7 +109,23 @@ FIXES
109109
- MSVC: Erroneous construction of the installed msvc list (as described above) caused an
110110
index error in the msvc support code. An explicit check was added to prevent indexing
111111
into an empty list. Fixes #4312.
112-
- MSVC: VS2015 Express (14.1Exp) may not have been detected. VS2015 Express should
112+
- MSVC: The search for the msvc compiler executable (cl.exe) no longer inspects the
113+
OS system path in certain situations when setting up the msvc environment.
114+
- MSCommon: Test SConfTests.py would fail when mscommon debugging was enabled via the
115+
MSVC_MSCOMMON_DEBUG environment variable. The mscommon logging filter class registered
116+
with the python logging module was refactored to prevent test failure.
117+
- MSVS: Add arm64 to the MSVS supported architectures list for VS2017 and later to be
118+
consistent with the current documentation of MSVS_ARCH.
119+
- FORTRAN: Fix gfortran tool initialization. Defaults to using binary named gfortran
120+
as would be expected, and properly set's SHFORTRAN flags to include -fPIC
121+
where previously it was only doing so for the other fortran versions (F77,..)
122+
- MSCommon: Added more error handling while reading msvc config cache.
123+
(Enabled/specified by SCONS_CACHE_MSVC_CONFIG).
124+
The existing cache will be discarded if there's a decode error reading it.
125+
It's possible there's a race condition creating this issue it in certain CI builds.
126+
- Fixed: race condition in `Mkdir` which can happen when two `SConscript`
127+
are processed simultaneously by two separate build commands.
128+
- MSVC: VS2015 Express (14.0Exp) may not have been detected. VS2015 Express should
113129
be correctly detected.
114130
- MSVC: VS2010 (10.0) could be inadvertently detected due to an sdk-only install
115131
of Windows SDK 7.1. An sdk-only install of VS2010 is ignored as the msvc batch
@@ -122,43 +138,27 @@ FIXES
122138
- MSVC: VS2008 (9.0) Visual C++ For Python was not detected when installed using the
123139
ALLUSERS=1 option (i.e., msiexec /i VCForPython27.msi ALLUSERS=1). When installed
124140
for all users, VS2008 (9.0) Visual C++ For Python is now correctly detected.
125-
- MSVC: The search for the msvc compiler executable (cl.exe) no longer inspects the
126-
OS system path in certain situations when setting up the msvc environment.
127141
- MSVC: The installed vcs list was constructed and cached during the initial
128142
invocation. If a vswhere executable was specified via the construction variable
129143
VSWHERE and found additional msvc installations, the new installations were not
130144
reflected in the installed vcs list. Now, when a user-specified vswhere executable
131145
finds new msvc installations, the installed vcs list is reconstructed.
132-
- MSCommon: Test SConfTests.py would fail when mscommon debugging was enabled via the
133-
MSVC_MSCOMMON_DEBUG environment variable. The mscommon logging filter class registered
134-
with the python logging module was refactored to prevent test failure.
135-
- MSVS: Add arm64 to the MSVS supported architectures list for VS2017 and later to be
136-
consistent with the current documentation of MSVS_ARCH.
137-
- FORTRAN: Fix gfortran tool initialization. Defaults to using binary named gfortran
138-
as would be expected, and properly set's SHFORTRAN flags to include -fPIC
139-
where previously it was only doing so for the other fortran versions (F77,..)
140-
- MSCommon: Added more error handling while reading msvc config cache.
141-
(Enabled/specified by SCONS_CACHE_MSVC_CONFIG).
142-
The existing cache will be discarded if there's a decode error reading it.
143-
It's possible there's a race condition creating this issue it in certain CI builds.
144-
- Fixed: race condition in `Mkdir` which can happen when two `SConscript`
145-
are processed simultaneously by two separate build commands.
146146

147147
IMPROVEMENTS
148148
------------
149149

150150
- Now tries to find mingw if it comes from Chocolatey install of msys2.
151-
- MSVC: VS2015 Express (14.1Exp) does not support the sdk version argument. VS2015
152-
Express does not support the store argument for target architectures other than
153-
x86. Script argument validation now takes into account these restrictions.
154-
- MSVC: VS2015 BuildTools (14.0) does not support the sdk version argument and
155-
does not support the store argument. Script argument validation now takes into
156-
account these restrictions.
157151
- MSVC: Module imports were changed from a relative import to a top-level
158152
absolute import in the following Microsoft tools: midl, mslib, mslink, mssdk, msvc,
159153
msvs. Moving any of these tools that used relative imports to the scons site tools
160154
folder would fail on import (i.e., the relative import paths become invalid when
161155
moved).
156+
- MSVC: VS2015 Express (14.0Exp) does not support the sdk version argument. VS2015
157+
Express does not support the store argument for target architectures other than
158+
x86. Script argument validation now takes into account these restrictions.
159+
- MSVC: VS2015 BuildTools (14.0) does not support the sdk version argument and
160+
does not support the store argument. Script argument validation now takes into
161+
account these restrictions.
162162

163163
PACKAGING
164164
---------

0 commit comments

Comments
 (0)