cache push on any thread

Author: acmorrow

SCons/Node/NodeTests.py

@@ -1296,15 +1296,13 @@ def test_clear(self) -> None:
         n.includes = 'testincludes'
         n.Tag('found_includes', {'testkey':'testvalue'})
         n.implicit = 'testimplicit'
-        n.cached = 1
 
         x = MyExecutor()
         n.set_executor(x)
 
         n.clear()
 
         assert n.includes is None, n.includes
-        assert n.cached == 0, n.cached
         assert x.cleaned_up
 
     def test_get_subst_proxy(self) -> None:

SCons/Node/__init__.py

@@ -588,7 +588,6 @@ def __init__(self) -> None:
         self.pseudo = False
         self.noclean = 0
         self.nocache = 0
-        self.cached = 0 # is this node pulled from cache?
         self.always_build = None
         self.includes = None
         self.attributes = self.Attrs() # Generic place to stick information about the Node.
@@ -864,7 +863,6 @@ def clear(self) -> None:
                 delattr(self, attr)
             except AttributeError:
                 pass
-        self.cached = 0
         self.includes = None
 
     def clear_memoized_values(self) -> None:

SCons/Taskmaster/__init__.py

@@ -244,9 +244,8 @@ def execute(self):
                         SCons.Warnings.warn(SCons.Warnings.CacheCleanupErrorWarning,
                             "Failed copying all target files from cache, Error while attempting to remove file %s retrieved from cache: %s" % (t.get_internal_path(), e))
                 self.targets[0].build()
-            else:
-                for t in cached_targets:
-                    t.cached = 1
+                for t in self.targets:
+                    t.push_to_cache()
         except SystemExit:
             exc_value = sys.exc_info()[1]
             raise SCons.Errors.ExplicitExit(self.targets[0], exc_value.code)
@@ -299,8 +298,6 @@ def executed_with_callbacks(self) -> None:
                 for side_effect in t.side_effects:
                     side_effect.set_state(NODE_NO_STATE)
                 t.set_state(NODE_EXECUTED)
-                if not t.cached:
-                    t.push_to_cache()
                 t.built()
                 t.visited()
                 if (not print_prepare and