refactoring

Author: pioner921227

cpp/JSManager.cpp

@@ -6,8 +6,8 @@
 //
 
 #include "JSManager.hpp"
-#include "TaskScheduler.h"
-#include "constants.h"
+#include "TaskScheduler.hpp"
+#include "constants.hpp"
 #include "helpers/helpers.h"
 
 jsi::Object createJSTaskManager(jsi::Runtime& rt) {

cpp/JSManager.hpp

@@ -8,15 +8,10 @@
 #ifndef JSManager_hpp
 #define JSManager_hpp
 
-#include <stdio.h>
-
-
 #include "jsi/jsi.h"
 
-using namespace facebook;
-
 
-jsi::Object createJSTaskManager(jsi::Runtime& rt);
+facebook::jsi::Object createJSTaskManager(facebook::jsi::Runtime& rt);
 
 
 

cpp/JSTask.cpp

@@ -8,13 +8,11 @@
 #ifndef JSTask_hpp
 #define JSTask_hpp
 
-#include <stdio.h>
-
 #include "jsi/jsi.h"
 #include <ReactCommon/CallInvoker.h>
 
-using namespace facebook;
 
-jsi::Function createJSTaskCreator(jsi::Runtime& rt,std::shared_ptr<react::CallInvoker> callInvoker);
+facebook::jsi::Function createJSTaskCreator(facebook::jsi::Runtime& rt,
+                                            std::shared_ptr<facebook::react::CallInvoker> callInvoker);
 
 #endif /* JSTask_hpp */

cpp/JSTask.hpp

@@ -12,6 +12,7 @@
 #include "jsi/jsi.h"
 #include "queue"
 #include "thread"
+#include "constants.hpp"
 
 using namespace std;
 using namespace facebook;

cpp/TaskScheduler.h cpp/TaskScheduler.hppcpp/TaskScheduler.h renamed to cpp/TaskScheduler.hpp

@@ -8,8 +8,7 @@
 #pragma once
 
 #include <curl/curl.h>
-#include <tuple>
-#include <iostream>
+
 
 using namespace std;
 

cpp/constants.h cpp/constants.hppcpp/constants.h renamed to cpp/constants.hpp

@@ -9,19 +9,17 @@
 
 #include "jsi/jsi.h"
 
-using namespace facebook;
-
 
 template<typename T>
-inline bool checkJSType(jsi::Runtime& rt, const jsi::Value& val);
+inline bool checkJSType(facebook::jsi::Runtime& rt, const facebook::jsi::Value& val);
 
 template<>
-inline bool checkJSType<jsi::Function>(jsi::Runtime& rt, const jsi::Value& val) {
+inline bool checkJSType<facebook::jsi::Function>(facebook::jsi::Runtime& rt, const facebook::jsi::Value& val) {
   return val.isObject() && val.asObject(rt).isFunction(rt);
 };
 
 template<>
-inline bool checkJSType<jsi::Array>(jsi::Runtime& rt, const jsi::Value& val) {
+inline bool checkJSType<facebook::jsi::Array>(facebook::jsi::Runtime& rt, const facebook::jsi::Value& val) {
   return val.isObject() && val.asObject(rt).isArray(rt);
 };
 

cpp/helpers/fetch.h

@@ -1,7 +1,7 @@
-#include "react-native-sync-tasks.h"
+#include "react-native-sync-tasks.hpp"
 #include "JSManager.hpp"
 #include "JSTask.hpp"
-#include "constants.h"
+#include "constants.hpp"
 
 
 using namespace sh;