[ECS-Plugin] Fix lint (#6588)

* fix: return filter tasksets

Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>

* chore: fix lint issues

Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>

---------

Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>

Author: armistcxy

pkg/app/pipedv1/plugin/ecs/deployment/plugin.go

@@ -18,8 +18,9 @@ import (
 	"context"
 	"errors"
 
-	ecsconfig "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 	sdk "github.com/pipe-cd/piped-plugin-sdk-go"
+
+	ecsconfig "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 )
 
 var _ sdk.DeploymentPlugin[ecsconfig.ECSPluginConfig, ecsconfig.ECSDeployTargetConfig, ecsconfig.ECSApplicationSpec] = (*ECSPlugin)(nil)

pkg/app/pipedv1/plugin/ecs/deployment/sync.go

@@ -19,9 +19,10 @@ import (
 	"fmt"
 
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
+	sdk "github.com/pipe-cd/piped-plugin-sdk-go"
+
 	ecsconfig "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/provider"
-	sdk "github.com/pipe-cd/piped-plugin-sdk-go"
 )
 
 func (p *ECSPlugin) executeECSSyncStage(

pkg/app/pipedv1/plugin/ecs/deployment/test_helper.go

@@ -19,6 +19,7 @@ import (
 	"time"
 
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
+
 	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/provider"
 
 	appconfig "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"

pkg/app/pipedv1/plugin/ecs/main.go

@@ -17,8 +17,9 @@ package main
 import (
 	"log"
 
-	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/deployment"
 	sdk "github.com/pipe-cd/piped-plugin-sdk-go"
+
+	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/deployment"
 )
 
 func main() {

pkg/app/pipedv1/plugin/ecs/provider/client.go

@@ -24,6 +24,7 @@ import (
 	"github.com/aws/aws-sdk-go-v2/credentials/stscreds"
 	"github.com/aws/aws-sdk-go-v2/service/ecs"
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
+
 	"github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider"
 	"github.com/pipe-cd/pipecd/pkg/backoff"
 
@@ -188,15 +189,15 @@ func (c *client) GetServiceTaskSets(ctx context.Context, service types.Service)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get task sets of service %s: %w", *service.ServiceName, err)
 	}
-	taskSets := make([]*types.TaskSet, 0, len(tsOutput.TaskSets))
+	taskSets := make([]types.TaskSet, 0, len(tsOutput.TaskSets))
 	for i := range tsOutput.TaskSets {
 		if !IsPipeCDManagedTaskSet(&tsOutput.TaskSets[i]) {
 			continue
 		}
-		taskSets = append(taskSets, &tsOutput.TaskSets[i])
+		taskSets = append(taskSets, tsOutput.TaskSets[i])
 	}
 
-	return svc.TaskSets, nil
+	return taskSets, nil
 }
 
 func (c *client) CreateTaskSet(ctx context.Context, service types.Service, taskDefinition types.TaskDefinition, targetGroup *types.LoadBalancer, scale float64) (*types.TaskSet, error) {

pkg/app/pipedv1/plugin/ecs/provider/ecs.go

@@ -21,9 +21,10 @@ import (
 
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
-	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 	sdk "github.com/pipe-cd/piped-plugin-sdk-go"
 	"golang.org/x/sync/singleflight"
+
+	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 )
 
 const (

pkg/app/pipedv1/plugin/ecs/provider/target_group.go

@@ -19,6 +19,7 @@ import (
 
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
+
 	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 )
 

pkg/app/pipedv1/plugin/ecs/provider/target_group_test.go

@@ -19,8 +19,9 @@ import (
 
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
-	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 	"github.com/stretchr/testify/assert"
+
+	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/ecs/config"
 )
 
 func TestLoadTargetGroups(t *testing.T) {