Skip to content

Commit 4557c0a

Browse files
committed
Reverting the errors
Signed-off-by: ansita20 <ansitasingh20@gmail.com>
1 parent cb01a54 commit 4557c0a

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ We host the [PipeCD Development and Community Meetings](https://zoom-lfx.platfor
3636

3737
### Join our team on GitHub
3838

39-
We welcome and appreciate your contributions to the PipeCD project. If you would like to continue contributing to the project as a member of the pipe-cd GitHub organization, please attend the [public community meeting](https://zoom-lfx.platform.linuxfoundation.org/meeting/96831504919?password=2f60b8ec-5896-40c8-aa1d-d551ab339d00) and let us know or ping us on the #pipecd channel in the CNCF Slack. Here are some minimum requirements to have before you can ask for the membership:
39+
We welcome and appreciate your contributions to the PipeCD project. If you would like to continue contributing to the project as a member of the pipe-cd GitHub organization, please attend the [public community meeting](#join-our-public-community-meeting) and let us know or ping us on the #pipecd channel in the CNCF Slack. Here are some minimum requirements to have before you can ask for the membership:
4040

4141
- Have at least 5 PRs successfully merged to repositories in the pipe-cd GitHub organization
4242
- Have attended PipeCD public community meeting

pkg/app/piped/eventwatcher/eventwatcher.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ func (w *watcher) execute(ctx context.Context, repo git.Repo, repoID string, eve
350350
gitUpdateEvent = false
351351
branchHandledEvents = make(map[string][]*pipedservice.ReportEventStatusesRequest_Event, len(eventCfgs))
352352
gitNoChangeEvents = make([]*pipedservice.ReportEventStatusesRequest_Event, 0)
353-
failureEvents = make([]*pipedservice.ReportEventStatusesRequest_Event, 0)
354353
)
355354
for _, e := range eventCfgs {
356355
for _, cfg := range e.Configs {
@@ -436,12 +435,6 @@ func (w *watcher) execute(ctx context.Context, repo git.Repo, repoID string, eve
436435
zap.String("event-name", latestEvent.Name),
437436
zap.String("event-id", latestEvent.Id),
438437
)
439-
handledEvent := &pipedservice.ReportEventStatusesRequest_Event{
440-
Id: latestEvent.Id,
441-
Status: model.EventStatus_EVENT_FAILURE,
442-
StatusDescription: fmt.Sprintf("Event watcher handler type %s is not supported", handler.Type),
443-
}
444-
failureEvents = append(failureEvents, handledEvent)
445438
continue
446439
}
447440
}
@@ -454,14 +447,6 @@ func (w *watcher) execute(ctx context.Context, repo git.Repo, repoID string, eve
454447
w.logger.Info(fmt.Sprintf("successfully made %d events OUTDATED", len(outDatedEvents)))
455448
}
456449

457-
if len(failureEvents) > 0 {
458-
if _, err := w.apiClient.ReportEventStatuses(ctx, &pipedservice.ReportEventStatusesRequest{Events: failureEvents}); err != nil {
459-
w.logger.Error("failed to report event failure statuses", zap.Error(err))
460-
return err
461-
}
462-
w.logger.Info(fmt.Sprintf("successfully reported %d event failures", len(failureEvents)))
463-
}
464-
465450
if !gitUpdateEvent {
466451
return nil
467452
}

0 commit comments

Comments
 (0)