Skip to content

[docs] Fix links to analysisProvider config pages#5525

Merged
t-kikuc merged 1 commit intomasterfrom
docs/fix-link-analysisprovider
Feb 3, 2025
Merged

[docs] Fix links to analysisProvider config pages#5525
t-kikuc merged 1 commit intomasterfrom
docs/fix-link-analysisprovider

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 31, 2025

What this PR does:

as title

Why we need it:

The current links to analysisProvider config are invalid since the directory is wrong.

Now (wrong):
https://pipecd.dev/docs-v0.50.x/user-guide/configuration-reference/

Correct:
https://pipecd.dev/docs-v0.50.x/user-guide/managing-piped/configuration-reference/#analysisproviderprometheusconfig

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc enabled auto-merge (squash) January 31, 2025 15:17
@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.44%. Comparing base (6f4d443) to head (73e6fe9).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5525   +/-   ##
=======================================
  Coverage   26.43%   26.44%           
=======================================
  Files         464      465    +1     
  Lines       49786    49858   +72     
=======================================
+ Hits        13163    13186   +23     
- Misses      35569    35618   +49     
  Partials     1054     1054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit 7def8e8 into master Feb 3, 2025
14 checks passed
@t-kikuc t-kikuc deleted the docs/fix-link-analysisprovider branch February 3, 2025 07:26
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants