[Stage Plugins] Define Notifier APIs of Approved and WaitApproval#5538
Closed
[Stage Plugins] Define Notifier APIs of Approved and WaitApproval#5538
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5538 +/- ##
=======================================
Coverage 26.43% 26.44%
=======================================
Files 465 465
Lines 49858 49858
=======================================
+ Hits 13182 13186 +4
+ Misses 35621 35618 -3
+ Partials 1055 1054 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
I'll refine in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
The WaitApproval plugin needs to:
NotificationEventDeploymentWaitApproval)NotificationEventDeploymentApproved)cf.
pipecd/pkg/app/piped/executor/waitapproval/waitapproval.go
Lines 112 to 143 in 2ce020e
They depend on the current matcher/sender configs.
Note
Other notifications must NOT be triggered by plugins (e.g. DeploymentStarted, StageFinished)
If a plugin wants to send other customized notifications, the plugin should do so within the plugin without the pipedservice.
These pipedservice methods can be used by other plugins
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: