Change DeployTargets to DeployTargetsByPlugin in model.Application#5543
Merged
khanhtc1202 merged 2 commits intomasterfrom Feb 6, 2025
Merged
Change DeployTargets to DeployTargetsByPlugin in model.Application#5543khanhtc1202 merged 2 commits intomasterfrom
khanhtc1202 merged 2 commits intomasterfrom
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5543 +/- ##
==========================================
- Coverage 26.43% 26.43% -0.01%
==========================================
Files 465 465
Lines 49860 49885 +25
==========================================
+ Hits 13182 13188 +6
- Misses 35624 35643 +19
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
ffjlabo
approved these changes
Feb 6, 2025
Warashi
approved these changes
Feb 6, 2025
This was referenced Feb 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We need to use not just deploy targets but plugins while deploying applications and the current model.Application that contains only deployTargets is not enough. By adding this, pipedv1 can use both plugins and deploy targets while performing the deployment task.
Which issue(s) this PR fixes:
Part of #4980 #5252
Does this PR introduce a user-facing change?: