Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5549 +/- ##
==========================================
- Coverage 26.42% 26.41% -0.01%
==========================================
Files 465 465
Lines 49907 49907
==========================================
- Hits 13189 13185 -4
- Misses 35663 35666 +3
- Partials 1055 1056 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Warashi |
@ffjlabo Thank you for your comment. |
ffjlabo
left a comment
There was a problem hiding this comment.
Sorry, I forgot to approve 🙏 LGTM
What this PR does:
Build a Go binary with the host platform using the GOOS/GOARCH option and copy it to the target container image.
ref; https://docs.docker.com/build/building/multi-platform/#cross-compiling-a-go-application
Why we need it:
We sometimes face build failure at go build. I think this comes from QEMU and Go combination. So I changed the Dockerfile to build go binary without QEMU.
https://github.com/pipe-cd/pipecd/actions/runs/13126728528/job/36624384578#step:8:1
Which issue(s) this PR fixes:
Maybe fixes #5548
Does this PR introduce a user-facing change?: No