Revert "Change DeployTargets to DeployTargetsByPlugin in model.Application"#5554
Merged
Revert "Change DeployTargets to DeployTargetsByPlugin in model.Application"#5554
Conversation
ffjlabo
requested review from
Warashi,
khanhtc1202 and
t-kikuc
as code owners
…ation (#…" This reverts commit ea25ab8. Signed-off-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
ffjlabo
force-pushed
the
revert-5543-update-model-application
branch
from
99ccdaf to
c26f850
Compare
khanhtc1202
approved these changes
Feb 7, 2025
t-kikuc
approved these changes
Feb 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
+ Coverage 26.42% 26.44% +0.02%
==========================================
Files 465 465
Lines 49887 49862 -25
==========================================
+ Hits 13182 13188 +6
+ Misses 35651 35620 -31
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5543
Because google.protobuf.ListValue seems not suppported in Firestore...