Skip to content

Fix error deprecate overlap in badge component - setting/piped#5557

Merged
t-kikuc merged 1 commit intomasterfrom
fix/error-deprecated-badge-overlap
Feb 7, 2025
Merged

Fix error deprecate overlap in badge component - setting/piped#5557
t-kikuc merged 1 commit intomasterfrom
fix/error-deprecated-badge-overlap

Conversation

@hongky-1994
Copy link
Contributor

What this PR does:

  • Add overlap="rectangular" to suppress warning "deprecated"

Why we need it:

  • Clean error console
Warning: Failed prop type: Material-UI: `overlap="rectangle"` was deprecated. Use `overlap="rectangular"` instead.

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?: None

  • How are users affected by this change: None
  • Is this breaking change: No
  • How to migrate (if breaking change): No

Signed-off-by: kypham <hongkyhvnh@gmail.com>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@t-kikuc t-kikuc enabled auto-merge (squash) February 7, 2025 09:20
@t-kikuc t-kikuc merged commit f52a27b into master Feb 7, 2025
12 checks passed
@t-kikuc t-kikuc deleted the fix/error-deprecated-badge-overlap branch February 7, 2025 09:22
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.41%. Comparing base (65c1c3d) to head (f64f686).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5557      +/-   ##
==========================================
- Coverage   26.42%   26.41%   -0.02%     
==========================================
  Files         465      465              
  Lines       49911    49911              
==========================================
- Hits        13189    13183       -6     
- Misses      35667    35673       +6     
  Partials     1055     1055              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants