Handle SkipStage Options in v1 scheduler#5559
Merged
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
…n/skip/1-use-clone Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
Warashi,
ffjlabo and
khanhtc1202
as code owners
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Member
|
@t-kikuc |
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5559 +/- ##
==========================================
- Coverage 26.42% 26.34% -0.09%
==========================================
Files 465 469 +4
Lines 49911 50239 +328
==========================================
+ Hits 13189 13235 +46
- Misses 35667 35943 +276
- Partials 1055 1061 +6 ☔ View full report in Codecov by Sentry. |
Member
Author
khanhtc1202
reviewed
Feb 18, 2025
| @@ -0,0 +1,97 @@ | |||
| // Copyright 2024 The PipeCD Authors. | |||
Member
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 The PipeCD Authors. | |
| // Copyright 2025 The PipeCD Authors. |
Member
Author
There was a problem hiding this comment.
@khanhtc1202
Thank you, I fixed it: 924d8e4
@Warashi Sorry, please approve again 🙏
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
Basically, I copied from
pkg/app/piped/controller/skipstage.goand its test.Note:
I added
skipOnunderPipelineStage, not underWith.skipOnoption using git commands, and plugin-specific stage options should not have it.Although I used git clone as pipedv0, we should not do so to avoid unnecessary cloning.
Why we need it:
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: