Skip to content

Update application-detail-page, deployment-detail-page with deployment target info row#5562

Merged
t-kikuc merged 2 commits intomasterfrom
fix/application-detail-show-deploy-target
Feb 13, 2025
Merged

Update application-detail-page, deployment-detail-page with deployment target info row#5562
t-kikuc merged 2 commits intomasterfrom
fix/application-detail-show-deploy-target

Conversation

@hongky-1994
Copy link
Contributor

What this PR does:
As titile

Why we need it:
For pages application-detail and deployment-target that using piped v1,

  • there is no platformProvider and kind information
  • there are new data deployment Targets

Which issue(s) this PR fixes:

Fixes #5561

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…t target info row

Signed-off-by: kypham <hongkyhvnh@gmail.com>
Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 marked this pull request as ready for review February 12, 2025 09:23
@hongky-1994 hongky-1994 self-assigned this Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.39%. Comparing base (7d2818a) to head (3a4b893).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   26.38%   26.39%           
=======================================
  Files         465      465           
  Lines       49940    49940           
=======================================
+ Hits        13179    13183    +4     
+ Misses      35705    35702    -3     
+ Partials     1056     1055    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc changed the title Update application-detail-page, deployment-detail-page with deploymentt target info row Update application-detail-page, deployment-detail-page with deployment target info row Feb 13, 2025
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 2b78122 into master Feb 13, 2025
18 checks passed
@t-kikuc t-kikuc deleted the fix/application-detail-show-deploy-target branch February 13, 2025 02:07
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Web UI show deployment-target for application-detial page and deployment-detail page

3 participants